Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accessibility): Drag and Drop feature is not keyboard accessible #346

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

mariang-ens
Copy link
Contributor

JIRA Ticket: https://jira.corp.adobe.com/browse/SITES-2864

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mariang-ens mariang-ens changed the title SITES-2864 Accessibility - Drag and Drop feature is not keyboard accessible fix(Accessibility): Drag and Drop feature is not keyboard accessible Apr 23, 2024
@mmoisoiu
Copy link

mmoisoiu commented May 9, 2024

@majornista can you please review this PR and confirm if all the raised items from #242 are now addressed ?

Distinguish between screen reader initiated clicks to drag so that mousedown or touchstart events don't initiate a mouse drag event instead of the keyboard drag.
@Pareesh Pareesh merged commit d762873 into adobe:master Jul 30, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
## [4.16.3](v4.16.2...v4.16.3) (2024-07-30)

### Bug Fixes

* **Accessibility:** Drag and Drop feature is not keyboard accessible ([#346](#346)) ([d762873](d762873))
Pareesh pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants