Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Accessibility): Drag and Drop feature is not keyboard accessible #346

Merged
merged 5 commits into from
Jul 30, 2024
Merged

fix(Accessibility): Drag and Drop feature is not keyboard accessible #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d61c070
SITES-2864 drag & drop feature is now keyboard accessible
Apr 22, 2024
daa3949
SITES-2864 drag & drop feature is now keyboard accessible
Apr 25, 2024
dde0173
fixed unit test
Apr 25, 2024
ad851c2
SITES-2864 drag & drop screen reader improvements
majornista May 31, 2024
7f50fa8
Merge branch 'master' into issue/SITES-2864
majornista May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion coral-component-dialog/src/tests/test.Dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ describe('Dialog', function () {
clientX: x,
clientY: y,
bubbles: true,
cancelable: true
cancelable: true,
pointerType: 'mouse',
detail: 1
});
};

Expand Down
24 changes: 12 additions & 12 deletions coral-component-table/examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128" alt="thumbnail">
<img alt="" src="https://via.placeholder.com/128x128" alt="thumbnail">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -197,7 +197,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand All @@ -208,7 +208,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Alpha</td>
<td is="coral-table-cell">January 28, 2012</td>
Expand All @@ -219,7 +219,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Beta</td>
<td is="coral-table-cell">December 1, 2011</td>
Expand All @@ -230,7 +230,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -240,7 +240,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand Down Expand Up @@ -289,7 +289,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128" alt="thumbnail">
<img alt="" src="https://via.placeholder.com/128x128" alt="thumbnail">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -299,7 +299,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand All @@ -309,7 +309,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Alpha</td>
<td is="coral-table-cell">January 28, 2012</td>
Expand All @@ -319,7 +319,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Beta</td>
<td is="coral-table-cell">December 1, 2011</td>
Expand All @@ -329,7 +329,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -339,7 +339,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand Down
4 changes: 3 additions & 1 deletion coral-component-table/i18n/translations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export default {
"sorted by column {0}, in ascending order": "sorted by column {0} in ascending order",
"sorted by column {0}, in descending order": "sorted by column {0} in descending order",
", checked": ", checked",
", unchecked": ", unchecked"
", unchecked": ", unchecked",
"reordering": "reordering",
"reordered to row {0}": "reordered to row {0}",
},
"de-DE": {
"Select": "Auswählen",
Expand Down
Loading
Loading