From 908a51600394f69cd01c51a1bf07a23b23eecbb6 Mon Sep 17 00:00:00 2001 From: ens13533 Date: Wed, 10 Jul 2024 09:40:11 +0300 Subject: [PATCH 1/6] removed attributes not allowed by axeDevTools --- coral-component-columnview/src/scripts/ColumnViewPreview.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/coral-component-columnview/src/scripts/ColumnViewPreview.js b/coral-component-columnview/src/scripts/ColumnViewPreview.js index 919c9326b2..63e900abf8 100644 --- a/coral-component-columnview/src/scripts/ColumnViewPreview.js +++ b/coral-component-columnview/src/scripts/ColumnViewPreview.js @@ -99,17 +99,11 @@ const ColumnViewPreview = Decorator(class extends BaseComponent(HTMLElement) { // @a11y If the previous column has selected items, // do not include item values in the tab order, // so that a keyboard user can quickly advance to a subsequent toolbar. - const tabIndex = (this.parentElement && - this.parentElement.tagName === 'CORAL-COLUMNVIEW' && - this.parentElement.selectedItems.length) ? -1 : 0; for (i = 0 ; i < length ; i++) { element = elements[i]; elementLabel = element.previousElementSibling; elementLabel.id = elementLabel.id || commons.getUID(); - element.setAttribute('aria-labelledby', elementLabel.id); - element.setAttribute('role', 'textbox'); - element.setAttribute('tabindex', tabIndex); element.setAttribute('aria-readonly', 'true'); // force ChromeVox to read value of textbox From 5350ba5480b910c45e4bb18524f7e28d249a003e Mon Sep 17 00:00:00 2001 From: ens13533 Date: Wed, 10 Jul 2024 09:50:24 +0300 Subject: [PATCH 2/6] removed attributes not allowed by axeDevTools --- .../src/tests/test.ColumnView.Preview.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/coral-component-columnview/src/tests/test.ColumnView.Preview.js b/coral-component-columnview/src/tests/test.ColumnView.Preview.js index 0328f03c82..3549b01790 100644 --- a/coral-component-columnview/src/tests/test.ColumnView.Preview.js +++ b/coral-component-columnview/src/tests/test.ColumnView.Preview.js @@ -74,9 +74,6 @@ describe('ColumnView.Preview', function () { element = elements[i]; elementLabel = element.previousElementSibling; elementLabel.id = elementLabel.id || commons.getUID(); - expect(element.getAttribute('aria-labelledby')).to.equal(elementLabel.id); - expect(element.getAttribute('role')).to.equal('textbox'); - expect(element.getAttribute('tabindex')).to.equal('0'); expect(element.getAttribute('aria-readonly')).to.equal('true'); } }); From 23dd7aef1c5e0e55ec7d460c87259d6a4876b09c Mon Sep 17 00:00:00 2001 From: ens13533 Date: Wed, 10 Jul 2024 10:14:30 +0300 Subject: [PATCH 3/6] removed attributes not allowed by axeDevTools --- coral-component-columnview/src/tests/test.ColumnView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/coral-component-columnview/src/tests/test.ColumnView.js b/coral-component-columnview/src/tests/test.ColumnView.js index b1359718e2..9def2e95a4 100644 --- a/coral-component-columnview/src/tests/test.ColumnView.js +++ b/coral-component-columnview/src/tests/test.ColumnView.js @@ -1574,11 +1574,11 @@ describe('ColumnView', function () { let focusables = el.querySelectorAll('coral-columnview-preview coral-columnview-preview-value[tabindex="-1"]'); let tabbables = el.querySelectorAll('coral-columnview-preview coral-columnview-preview-value[tabindex="0"]'); expect(focusables.length).to.equal(0); - expect(tabbables.length).to.equal(7); + expect(tabbables.length).to.equal(0); item.selected = true; focusables = el.querySelectorAll('coral-columnview-preview coral-columnview-preview-value[tabindex="-1"]'); tabbables = el.querySelectorAll('coral-columnview-preview coral-columnview-preview-value[tabindex="0"]'); - expect(focusables.length).to.equal(7); + expect(focusables.length).to.equal(0); expect(tabbables.length).to.equal(0); }) }); From 96814e7765bbddca9027930ef287b16b750833fd Mon Sep 17 00:00:00 2001 From: ens13533 Date: Thu, 11 Jul 2024 11:54:51 +0300 Subject: [PATCH 4/6] removed attributes not allowed by axeDevTools --- coral-component-columnview/src/scripts/ColumnViewPreview.js | 1 - coral-component-columnview/src/tests/test.ColumnView.Preview.js | 1 - 2 files changed, 2 deletions(-) diff --git a/coral-component-columnview/src/scripts/ColumnViewPreview.js b/coral-component-columnview/src/scripts/ColumnViewPreview.js index 63e900abf8..8036d15db7 100644 --- a/coral-component-columnview/src/scripts/ColumnViewPreview.js +++ b/coral-component-columnview/src/scripts/ColumnViewPreview.js @@ -104,7 +104,6 @@ const ColumnViewPreview = Decorator(class extends BaseComponent(HTMLElement) { element = elements[i]; elementLabel = element.previousElementSibling; elementLabel.id = elementLabel.id || commons.getUID(); - element.setAttribute('aria-readonly', 'true'); // force ChromeVox to read value of textbox if (window.cvox) { diff --git a/coral-component-columnview/src/tests/test.ColumnView.Preview.js b/coral-component-columnview/src/tests/test.ColumnView.Preview.js index 3549b01790..2188c46695 100644 --- a/coral-component-columnview/src/tests/test.ColumnView.Preview.js +++ b/coral-component-columnview/src/tests/test.ColumnView.Preview.js @@ -74,7 +74,6 @@ describe('ColumnView.Preview', function () { element = elements[i]; elementLabel = element.previousElementSibling; elementLabel.id = elementLabel.id || commons.getUID(); - expect(element.getAttribute('aria-readonly')).to.equal('true'); } }); From e757f45ac7cb228d8321e2221edeb975fcf9928d Mon Sep 17 00:00:00 2001 From: ens13533 Date: Mon, 15 Jul 2024 13:45:27 +0300 Subject: [PATCH 5/6] changed invalid aria-modal attribute value --- coral-component-dialog/src/scripts/Dialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coral-component-dialog/src/scripts/Dialog.js b/coral-component-dialog/src/scripts/Dialog.js index 33c5181df6..2e3f45b477 100644 --- a/coral-component-dialog/src/scripts/Dialog.js +++ b/coral-component-dialog/src/scripts/Dialog.js @@ -695,7 +695,7 @@ const Dialog = Decorator(class extends BaseOverlay(BaseComponent(HTMLElement)) { super.render(); this.classList.add(`${CLASSNAME}-wrapper`); - this.setAttribute("aria-modal", "dialog"); + this.setAttribute("aria-modal", "true"); // Default reflected attributes if (!this._variant) { From 79e5c9a55a373763d3950acf53ac821c33bd55f7 Mon Sep 17 00:00:00 2001 From: ens13533 Date: Mon, 15 Jul 2024 13:52:05 +0300 Subject: [PATCH 6/6] reverted last commit --- coral-component-dialog/src/scripts/Dialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coral-component-dialog/src/scripts/Dialog.js b/coral-component-dialog/src/scripts/Dialog.js index 2e3f45b477..33c5181df6 100644 --- a/coral-component-dialog/src/scripts/Dialog.js +++ b/coral-component-dialog/src/scripts/Dialog.js @@ -695,7 +695,7 @@ const Dialog = Decorator(class extends BaseOverlay(BaseComponent(HTMLElement)) { super.render(); this.classList.add(`${CLASSNAME}-wrapper`); - this.setAttribute("aria-modal", "true"); + this.setAttribute("aria-modal", "dialog"); // Default reflected attributes if (!this._variant) {