Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitized query strings on the website #240

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Apr 4, 2024

Description

added some basic sanitization for the query string to avoid some xss attacks

Motivation

Previously, this link would cause an alert to show up.

To-do list

  • This pull request is ready to merge.

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: edec78b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Apr 4, 2024

Run report for edec78b8

Total time: 19.3s | Comparison time: 17.8s | Estimated loss: 1.5s (8.0% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(~20.11) 1.2s Skipped
🟩 InstallNodeDeps(~20.11) 7.5s Passed
🟩 SyncNodeProject(contrast-colors) 0.1ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(ui:makeDistDir) 34.9ms Passed
🟩 RunTask(ui:copyCNAME) 19.3ms Passed
🟩 RunTask(ui:copyUIIcons) 58.3ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 49.3ms Passed
🟩 RunTask(ui:buildSite) 10.5s Passed
Touched files
docs/ui/package.json
docs/ui/src/index.js
docs/ui/src/js/addFromURL.js
docs/ui/src/js/params.js
docs/ui/src/js/utils.js
docs/ui/src/theme.js
pnpm-lock.yaml

@GarthDB GarthDB merged commit 05c906c into main Apr 4, 2024
3 checks passed
@GarthDB GarthDB deleted the garthdb/sanitizeQueryString branch April 4, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant