-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2 Select box tokens #196
S2 Select box tokens #196
Conversation
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
b98b49c
to
8d384a5
Compare
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
1a0895e
to
8d384a5
Compare
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
READING spectrum-tokens: STUDIO SYNC SUMMARY
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Description
Made the following changes to component layout tokens for both mobile and desktop.
New tokens
select-box-horizontal-minimum-height
select-box-horizontal-width
select-box-vertical-height
select-box-edge-to-checkbox
select-box-horizontal-end-to-content
select-box-horizontal-illustration-to-label
select-box-horizontal-label-to-description
select-box-horizontal-start-to-content
select-box-horizontal-top-to-content
select-box-top-to-checkbox
select-box-vertical-edge-to-content
select-box-vertical-illustration-to-label
Made the following changes to component color tokens for both light and dark.
New tokens
select-box-selected-border-color
Motivation and context
Added tokens needed for the new S2 select box component.
Related issue
https://jira.corp.adobe.com/browse/SDS-13834
Types of changes
Checklist: