Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up corner radius to match s2-foundations proposal #207

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 17, 2024

Description

Previously, S2 foundations was matching what was in S2 for corner radius, but this paper doc show it needs to be interim values between S1 and S2.

image

Motivation and context

from the paper doc: It feels like a quick, simple, straightforward solution.

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @GarthDB GarthDB requested a review from a team as a code owner October 17, 2024 17:41
    @mrcjhicks
    Copy link
    Collaborator

    TESTING foundations

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/foundations/

    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/drop-shadow/300: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/neutral/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/accent/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/informative/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/positive/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/notice/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/negative/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-gray: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-blue: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-green: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-orange: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-red: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-brown: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-cinnamon: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-celery: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-chartreuse: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-cyan: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-fuchsia: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-indigo: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-magenta: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-pink: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-purple: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-seafoam: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-silver: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-turquoise: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-yellow: ["wireframe"]

    SPECTRUM SYNC SUMMARY

    DEPRECATED TOKENS: (21) corner-radius-300, corner-radius-400, corner-radius-500, corner-radius-600, corner-radius-700, corner-radius-800, corner-radius-1000, corner-radius-small-default, corner-radius-medium-default, corner-radius-large-default, corner-radius-extra-large-default, corner-radius-full, corner-radius-small-size-small, corner-radius-small-size-medium, corner-radius-small-size-large, corner-radius-small-size-extra-large, corner-radius-medium-size-extra-small, corner-radius-medium-size-small, corner-radius-medium-size-medium, corner-radius-medium-size-large, corner-radius-medium-size-extra-large
    CHANGED VALUES: (3) corner-radius-75, corner-radius-100, corner-radius-200 impacting 7 tokens
    

    TEST COMPLETE

    @GarthDB GarthDB merged commit 6cffd5a into main Oct 21, 2024
    4 checks passed
    @GarthDB GarthDB deleted the garthdb/fix-s2-foundations-corner-radius branch October 21, 2024 17:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants