Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated desktop and mobile values for checkbox tokens #212

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

KayiuCarlson
Copy link
Contributor

Description

Updated desktop and mobile values for checkbox-control-size-[size] and checkbox-top-to-control-[size] tokens

Motivation and context

Updated values based on recent design changes on checkbox.

Related issue

n/a

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (2) action-bar-minimum-width, action-bar-label-to-action-group-area
    CHANGED VALUES: (16) checkbox-control-size-extra-large/desktop, checkbox-control-size-large/desktop, checkbox-control-size-medium/desktop, checkbox-control-size-small/desktop, checkbox-top-to-control-extra-large/desktop, checkbox-top-to-control-large/desktop, checkbox-top-to-control-medium/desktop, checkbox-top-to-control-small/desktop, checkbox-control-size-extra-large/mobile, checkbox-control-size-large/mobile, checkbox-control-size-medium/mobile, checkbox-control-size-small/mobile, checkbox-top-to-control-extra-large/mobile, checkbox-top-to-control-large/mobile, checkbox-top-to-control-medium/mobile, checkbox-top-to-control-small/mobile impacting 8 tokens
    

    TEST COMPLETE

    Copy link
    Collaborator

    @karstens karstens left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good to me! Thanks

    Copy link
    Contributor

    @lynnhao lynnhao left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This looks great!

    @GarthDB GarthDB merged commit 512887f into main Nov 21, 2024
    4 checks passed
    @GarthDB GarthDB deleted the kayiucarlson/SDS-14257-checkbox-tokens-update branch November 21, 2024 18:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants