Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated non gray 800 colors (s2-foundations) #213

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Nov 20, 2024

Description

Copying changes from this pr #165 into s2-foundations

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @GarthDB GarthDB requested a review from a team as a code owner November 20, 2024 21:03
    @mrcjhicks
    Copy link
    Collaborator

    TESTING foundations

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/foundations/

    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/drop-shadow/300: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/neutral/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/accent/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/informative/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/positive/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/notice/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/semantic/negative/subtle-default: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-gray: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-blue: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-green: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-orange: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-red: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-brown: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-cinnamon: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-celery: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-chartreuse: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-cyan: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-fuchsia: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-indigo: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-magenta: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-pink: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-purple: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-seafoam: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-silver: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-turquoise: ["wireframe"]
    WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum/alias/Alias/background/non-semantic/subtle-yellow: ["wireframe"]

    SPECTRUM SYNC SUMMARY

    CHANGED VALUES: (18) blue-800/dark, brown-800/dark, celery-800/dark, chartreuse-800/dark, cinnamon-800/dark, cyan-800/dark, fuchsia-800/dark, green-800/dark, indigo-800/dark, magenta-800/dark, orange-800/dark, pink-800/dark, purple-800/dark, red-800/dark, seafoam-800/dark, silver-800/dark, turquoise-800/dark, yellow-800/dark impacting 48 tokens
    

    TEST COMPLETE

    Copy link
    Collaborator

    @karstens karstens left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good to me! Thanks!

    Copy link
    Contributor

    @lynnhao lynnhao left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I just reviewed and everything looks good to me. here's what I confirmed:

    • 18 changes to dark theme palette colors matches the expected changes
    • all values now show the correct updated values based on expectation. for example, red-800 is now #DF3422 as expected

    I also double-checked some of the aliases that were already included in foundations and everything looks good as far as I can tell 🤞

    @GarthDB GarthDB merged commit 2eac3ee into main Nov 21, 2024
    4 checks passed
    @GarthDB GarthDB deleted the garthdb/s2-foundations-non-gray-800-colors-update branch November 21, 2024 20:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants