-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated non gray 800 colors (s2-foundations) #213
Updated non gray 800 colors (s2-foundations) #213
Conversation
READING spectrum-tokens:
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reviewed and everything looks good to me. here's what I confirmed:
- 18 changes to dark theme palette colors matches the expected changes
- all values now show the correct updated values based on expectation. for example, red-800 is now #DF3422 as expected
I also double-checked some of the aliases that were already included in foundations and everything looks good as far as I can tell 🤞
Description
Copying changes from this pr #165 into s2-foundations
Types of changes
Checklist: