-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Down state token updates #31
Conversation
…th a value of -2px. Updated component-size-width-ratio-down value from 3px to 0.3333 number token. This was updated in desktop and mobile.
READING spectrum-tokens: SPECTRUM SYNC SUMMARY
TEST COMPLETE |
Merging this because it is just a change from a previously merged pr that has already been approved and merged. |
READING spectrum-tokens: SPECTRUM SYNC SUMMARY
WROTE: SYNC COMPLETE |
"component-size-width-ratio-down": { | ||
"value": "3px", | ||
"value": "0.3333", | ||
"type": "sizing", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nabuhasan @lynnhao I totally missed that this token might not be of type 'sizing'. I think, this 'ratio' token and other tokens (like text-field-minimum-width-multiplier
) could be of type 'number'. I will scan through all the non-color tokens tomorrow and create a list of tokens, that might not be sizing tokens, if that is alright with you. Thanks Frank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, let me know where specific tokens should live and I can make the updates then! @karstens
Description
Replaced component-size-difference-down token to a dimension token with a value of -2px. To do this, I created a new dimension token and deleted the old token under sizing category in TS. I also referenced the same UUID in the new token since they are the same just reordered to a difference section. It didn't seem like there was a way for me to drag the token to a different category.
Updated component-size-width-ratio-down value from 3px to 0.3333 number token.
These updates were made to both desktop and mobile.
Motivation and context
Inaccuracies in token values of a previous branch needed to be addressed.
Related issue
Added 3 non-color tokens for S2 component down states #27
Types of changes
Checklist: