Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down state token updates #31

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

nabuhasan
Copy link
Contributor

Description

  • Replaced component-size-difference-down token to a dimension token with a value of -2px. To do this, I created a new dimension token and deleted the old token under sizing category in TS. I also referenced the same UUID in the new token since they are the same just reordered to a difference section. It didn't seem like there was a way for me to drag the token to a different category.

  • Updated component-size-width-ratio-down value from 3px to 0.3333 number token.

These updates were made to both desktop and mobile.

Motivation and context

Inaccuracies in token values of a previous branch needed to be addressed.

Related issue

Added 3 non-color tokens for S2 component down states #27

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type; fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

…th a value of -2px. Updated component-size-width-ratio-down value from 3px to 0.3333 number token. This was updated in desktop and mobile.
@nabuhasan nabuhasan self-assigned this Jan 10, 2024
@mrcjhicks
Copy link
Collaborator

TESTING spectrum2-non-colors

READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY

SPECTRUM SYNC SUMMARY

NEW TOKENS: (6) component-size-width-ratio-down/desktop, component-size-minimum-perspective-down/desktop, component-size-difference-down/desktop, component-size-width-ratio-down/mobile, component-size-minimum-perspective-down/mobile, component-size-difference-down/mobile
CHANGED VALUES: (26) workflow-icon-size-100/desktop, workflow-icon-size-200/desktop, workflow-icon-size-300/desktop, workflow-icon-size-100/mobile, workflow-icon-size-200/mobile, workflow-icon-size-300/mobile, workflow-icon-size-50/mobile, workflow-icon-size-75/mobile, component-top-to-workflow-icon-100/desktop, component-top-to-workflow-icon-200/desktop, component-top-to-workflow-icon-300/desktop, text-to-visual-100/desktop, text-to-visual-200/desktop, text-to-visual-300/desktop, text-to-visual-50/desktop, text-to-visual-75/desktop, component-top-to-workflow-icon-100/mobile, component-top-to-workflow-icon-200/mobile, component-top-to-workflow-icon-300/mobile, component-top-to-workflow-icon-50/mobile, component-top-to-workflow-icon-75/mobile, text-to-visual-100/mobile, text-to-visual-200/mobile, text-to-visual-300/mobile, text-to-visual-50/mobile, text-to-visual-75/mobile impacting 15 tokens

TEST COMPLETE

@GarthDB GarthDB merged commit 6ad239c into main Jan 10, 2024
3 checks passed
@GarthDB
Copy link
Member

GarthDB commented Jan 10, 2024

Merging this because it is just a change from a previously merged pr that has already been approved and merged.

@GarthDB GarthDB deleted the nabuhasan/SDS-13233-down-state-tokens-update branch January 10, 2024 23:00
@mrcjhicks
Copy link
Collaborator

SYNCING spectrum2-non-colors

READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY

SPECTRUM SYNC SUMMARY

NEW TOKENS: (6) component-size-width-ratio-down/desktop, component-size-minimum-perspective-down/desktop, component-size-difference-down/desktop, component-size-width-ratio-down/mobile, component-size-minimum-perspective-down/mobile, component-size-difference-down/mobile
CHANGED VALUES: (26) workflow-icon-size-100/desktop, workflow-icon-size-200/desktop, workflow-icon-size-300/desktop, workflow-icon-size-100/mobile, workflow-icon-size-200/mobile, workflow-icon-size-300/mobile, workflow-icon-size-50/mobile, workflow-icon-size-75/mobile, component-top-to-workflow-icon-100/desktop, component-top-to-workflow-icon-200/desktop, component-top-to-workflow-icon-300/desktop, text-to-visual-100/desktop, text-to-visual-200/desktop, text-to-visual-300/desktop, text-to-visual-50/desktop, text-to-visual-75/desktop, component-top-to-workflow-icon-100/mobile, component-top-to-workflow-icon-200/mobile, component-top-to-workflow-icon-300/mobile, component-top-to-workflow-icon-50/mobile, component-top-to-workflow-icon-75/mobile, text-to-visual-100/mobile, text-to-visual-200/mobile, text-to-visual-300/mobile, text-to-visual-50/mobile, text-to-visual-75/mobile impacting 15 tokens

WROTE: /spectrum-tokens/packages/tokens/src/layout.json

SYNC COMPLETE

Spectrum Tokens Pull Request

"component-size-width-ratio-down": {
"value": "3px",
"value": "0.3333",
"type": "sizing",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nabuhasan @lynnhao I totally missed that this token might not be of type 'sizing'. I think, this 'ratio' token and other tokens (like text-field-minimum-width-multiplier) could be of type 'number'. I will scan through all the non-color tokens tomorrow and create a list of tokens, that might not be sizing tokens, if that is alright with you. Thanks Frank

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, let me know where specific tokens should live and I can make the updates then! @karstens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants