Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aligns some new tokens with some spectrum-tokens optimization #33

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: aligns some new tokens with some spectrum-tokens optimization #33

merged 1 commit into from
Jan 11, 2024

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Jan 11, 2024 •
edited by karstens
Loading

Description

Motivation and context

Related issue

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type; fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

@mrcjhicks
Copy link
Collaborator Author

TESTING spectrum2-non-colors

READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY

TEST COMPLETE

@mrcjhicks mrcjhicks requested a review from karstens January 11, 2024 17:47
karstens
karstens approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@karstens karstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@karstens karstens merged commit a570f71 into main Jan 11, 2024
5 checks passed
@karstens karstens deleted the issue/spectrum-sync branch January 11, 2024 17:49
@mrcjhicks
Copy link
Collaborator Author

SYNCING spectrum2-non-colors

READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY

SYNC COMPLETE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karstens karstens karstens approved these changes

@GarthDB GarthDB GarthDB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcjhicks @GarthDB @karstens