Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aligns letter-spacing token schemas to "dimension" for consistency #223

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Dec 4, 2023

Description

cjk-letter-spacing & detail-letter-spacing should have the same type schema, this aligns them both to "dimension"

Motivation and Context

Token type consistency.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

cjk-letter-spacing & detail-letter-spacing should have the same type schema
Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: d553028

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrcjhicks mrcjhicks requested a review from GarthDB December 4, 2023 20:31
@GarthDB
Copy link
Member

GarthDB commented Dec 4, 2023

Run report for 6e98bf1e

Total time: 59.4s | Comparison time: 1m 35s | Estimated savings: 36.5s (38.0% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
🟩 SetupNodeTool(18.13.0) 4.5s Passed
🟩 InstallNodeDeps(18.13.0) 6.4s Passed
🟩 SyncNodeProject(tokens) 1ms Passed
🟩 SyncNodeProject(site) 1.2ms Passed
🟩 SyncNodeProject(visualizer) 1ms Passed
🟩 RunTask(tokens:buildTokens) 17.8s Passed
🟩 RunTask(tokens:buildManifest) 297ms Passed
🟩 RunTask(site:copySchema) 78.4ms Passed
🟩 RunTask(site:clean) 143.9ms Passed
🟩 RunTask(tokens:build) 23.8s Passed
🟩 RunTask(tokens:generateDiffResult) 1.4s Passed
🟩 RunTask(tokens:test) 26s Passed
🟩 RunTask(site:build) 23.8s Passed
🟩 RunTask(site:export) 2.7s Passed
🟩 RunTask(visualizer:typescript) 1.8s Passed
🟩 RunTask(visualizer:build) 2s Passed
Touched files
.changeset/heavy-brooms-teach.md
.github/workflows/deploy-docs.yml
.github/workflows/release.yml
.moon/toolchain.yml
package.json
packages/tokens/src/typography.json
pnpm-lock.yaml

@GarthDB GarthDB merged commit cbd50ed into main Dec 4, 2023
3 checks passed
@GarthDB GarthDB deleted the issue/fix--consisten-letterspacing-schema branch December 4, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants