Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates from spectrum-tokens-studio-data #230

Merged
merged 2 commits into from
Dec 13, 2023
+28 −2
Merged

feat: updates from spectrum-tokens-studio-data #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db7cfd
[create-pull-request] automated change
mrcjhicks Dec 8, 2023
d84f45f
chore(tokens): added changeset
GarthDB Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/tame-bobcats-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@adobe/spectrum-tokens": minor
---

Fixed bug in the light theme value for notice-background-color-default, from notice-color-800 to notice-color-600

## Design Motivation

While updating the badge component in Figma, we noticed a bug where notice-background-color-default in S2 was entered incorrectly for light theme, and should instead match the value for S1

## Token Diff

_Token values updated (1):_

- `notice-background-color-default`: `light`: `notice-color-800` -> `notice-color-600`
15 changes: 13 additions & 2 deletions packages/tokens/src/color-aliases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,19 @@
}
},
"notice-background-color-default": {
"value": "{notice-color-800}",
"uuid": "48f3445a-63d8-4477-a2f5-1fee6a022328"
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/color-set.json",
"sets": {
"dark": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/alias.json",
"value": "{notice-color-800}",
"uuid": "323428c1-792d-41b4-8a17-a12f1ac00e2a"
},
"light": {
"$schema": "https://opensource.adobe.com/spectrum-tokens/schemas/token-types/alias.json",
"value": "{notice-color-600}",
"uuid": "48f3445a-63d8-4477-a2f5-1fee6a022328"
}
}
},
"disabled-background-color": {
"value": "{gray-100}",
Expand Down
Loading