Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: diff-gen - incorrect identification of renamed tokens #427

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Oct 9, 2024

Description

diff-generator incorrectly identifies token renames due to an invalid uuid comparison. Both objects being compared should be first checked for valid uuids before comparing the uuids otherwise there can be a false positive when neither object has a uuid.

Related Issue

https://jira.corp.adobe.com/browse/DNA-1376

Motivation and Context

How Has This Been Tested?

v48 to v49 cli comparison

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrcjhicks mrcjhicks requested a review from GarthDB October 9, 2024 22:28
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 9ebc05a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Oct 9, 2024

Run report for 9ebc05ae

Total time: 14.5s | Comparison time: 15.5s | Estimated savings: 978.2ms (6.3% faster)

Action Time Status Info
🟩 SyncWorkspace 5.1ms Passed
⬛️ SetupToolchain(node:~20.12) 2.1s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.3ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 6.7s Passed
🟩 RunTask(diff:diff) 107.5ms Passed
🟩 RunTask(root:test) 2.1s Passed
🟩 RunTask(diff:test) 5.7s Passed
Touched files
tools/diff-generator/src/lib/renamed-token-detection.js

@mrcjhicks mrcjhicks changed the title fix: incorrect identification of renamed tokens fix: diff-gen - incorrect identification of renamed tokens Oct 9, 2024
@GarthDB GarthDB merged commit e360529 into main Oct 10, 2024
4 checks passed
@GarthDB GarthDB deleted the cable/fix-diffgen-renamed-token branch October 10, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants