Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: diff-gen - supports token values that are numeric #428

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mrcjhicks
Copy link
Collaborator

Description

diff-generator explicitly looks for token values of type 'string', but we introduced support for type 'number'. This checks the additional value type so the reporting of the value change is consistent with strings.

Related Issue

https://jira.corp.adobe.com/browse/DNA-1376

Motivation and Context

How Has This Been Tested?

v48 to v49 cli comparison

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: f707e39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrcjhicks mrcjhicks requested a review from GarthDB October 9, 2024 22:32
@GarthDB
Copy link
Member

GarthDB commented Oct 9, 2024

Run report for f707e390

Total time: 14.5s | Comparison time: 15.1s | Estimated savings: 612.7ms (4.0% faster)

Action Time Status Info
🟩 SyncWorkspace 5.4ms Passed
⬛️ SetupToolchain(node:~20.12) 2s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 7.2s Passed
🟩 RunTask(diff:diff) 103.4ms Passed
🟩 RunTask(root:test) 1.6s Passed
🟩 RunTask(diff:test) 5.4s Passed
Touched files
tools/diff-generator/src/lib/updated-token-detection.js

@mrcjhicks mrcjhicks changed the title fix: supports token values that are numeric fix: diff-gen - supports token values that are numeric Oct 9, 2024
@GarthDB GarthDB merged commit c522493 into main Oct 10, 2024
4 checks passed
@GarthDB GarthDB deleted the cable/fix-diffgen-numeric-values branch October 10, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants