Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visualizer #436

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix Visualizer #436

merged 2 commits into from
Oct 14, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 14, 2024

Description

Add support for token values to be numbers

Motivation and Context

Tokens recently changed to use numbers for certain values (multipliers, etc). This caused a bug in the visualizer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: a8e1a76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stvt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Oct 14, 2024

Run report for a8e1a769

Total time: 42.5s | Comparison time: 1m 20s | Estimated savings: 37.5s (46.9% faster)

Action Time Status Info
🟩 SyncWorkspace 5.3ms Passed
⬛️ SetupToolchain(node:~20.12) 2s Skipped
🟩 SyncProject(node, root) 0.2ms Passed
🟩 SyncProject(node, site) 0.3ms Passed
🟩 SyncProject(node, tokens) 0.3ms Passed
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, visualizer) 0.2ms Passed
🟩 SyncProject(node, csvGenerator) 0.4ms Passed
🟩 RunTask(site:copySchema) 39.6ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 8.3s Passed
🟩 RunTask(csvGenerator:generateCSV) 262.4ms Passed
🟩 RunTask(root:test) 2.3s Passed
🟩 RunTask(visualizer:typescript) 3.9s Passed
🟩 RunTask(tokens:buildManifest) 324.2ms Passed
🟩 RunTask(site:clean) 377ms Passed
🟩 RunTask(diff:diff) 429.4ms Passed
🟩 RunTask(csvGenerator:test) 3.5s Passed
🟩 RunTask(diff:test) 7.5s Passed
🟩 RunTask(visualizer:build) 3.1s Passed
🟩 RunTask(site:build) 25.8s Passed
And 5 more...
Expanded report
Action Time Status Info
🟩 RunTask(site:export) 109.1ms Passed
🟩 RunTask(tokens:buildTokens) 29s Passed
🟩 RunTask(tokens:build) 19.5ms Passed
🟩 RunTask(tokens:generateDiffResult) 2.2s Passed
🟩 RunTask(tokens:test) 3.2s Passed
Touched files
.changeset/real-lamps-pump.md
.moon/toolchain.yml
docs/visualizer/src/controllers/graph-data-source.ts
package.json

@GarthDB GarthDB merged commit 101e1e1 into main Oct 14, 2024
4 checks passed
@GarthDB GarthDB deleted the garthdb/fix-visualizer-numbers branch October 14, 2024 16:21
@GarthDB GarthDB mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant