Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: markdown automation stuff #440

Closed
wants to merge 6 commits into from

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Oct 23, 2024

Description

REFERENCE ONLY

For reviewing the integration into git workflow stuff - adding a markdown formatted diff as a comment.

There's a hook into the changeset config to trigger the creation of the markdown report, and a git workflow item added to grab that report and stick it in a comment.

The code entry into the token diff tool is "format-function". Which pulls in the actual diff function from index.js. I don't know what the actual function hook is re: changeset stuff, but it appears to be this getReleaseLine function.

https://jira.corp.adobe.com/browse/DNA-1381

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: d17559e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Oct 23, 2024

Run report for d17559e2

Total time: 3.5s | Comparison time: 3.5s | Estimated loss: 6.3ms (0.2% slower)

Action Time Status Info
🟩 SyncWorkspace 6.1ms Passed
⬛️ SetupToolchain(node:~20.12) 2.2s Skipped
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.3ms Passed
🟥 InstallWorkspaceDeps(node:~20.12) 1.3s Aborted
Touched files
.changeset/config.json
.github/workflows/diff-generator.yml
pnpm-lock.yaml
tools/diff-generator/src/lib/file-import.js
tools/diff-generator/src/lib/format-function.js
tools/diff-generator/src/lib/index.js
tools/diff-generator/src/lib/reports/report.txt

@mrcjhicks mrcjhicks closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants