Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix takeover dialog dimensions types #441

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 24, 2024

Description

Change takeover dialog dimensions to use percentages which were previously converted to ems by mistake.

Token Diff

Updated Tokens (2):

  • takeover-dialog-height: 1.00em -> 1.00%
  • takeover-dialog-width: 1.00em -> 1.00%

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: e649b12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@adobe/spectrum-tokens Patch
token-csv-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB GarthDB changed the title Garthdb/fix takeover dialog dimensions types fix takeover dialog dimensions types Oct 24, 2024
@GarthDB
Copy link
Member Author

GarthDB commented Oct 24, 2024

Run report for e649b125

Total time: 36s | Comparison time: 35.6s | Estimated loss: 440.8ms (1.2% slower)

Action Time Status Info
🟩 SyncWorkspace 5.7ms Passed
⬛️ SetupToolchain(node:~20.12) 2s Skipped
🟩 SyncProject(node, tokens) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 7.6s Passed
🟩 RunTask(tokens:buildManifest) 242.5ms Passed
🟩 RunTask(root:test) 1.3s Passed
🟩 RunTask(tokens:buildTokens) 23s Passed
🟩 RunTask(tokens:build) 16.6ms Passed
🟩 RunTask(tokens:generateDiffResult) 2.6s Passed
🟩 RunTask(tokens:test) 3.5s Passed
Touched files
.changeset/three-buttons-hunt.md
packages/tokens/src/layout-component.json

@GarthDB GarthDB merged commit 89949e4 into beta Oct 24, 2024
4 checks passed
@GarthDB GarthDB deleted the garthdb/fix-takeover-dialog-dimensions-types branch October 24, 2024 16:22
@GarthDB GarthDB mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant