-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for markdown output to the token diff tool #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into cable/reporting
... i can tell it is markdown now without this
... since npm versions aren't supported, yet, just git tags
... for workflow integration
🦋 Changeset detectedLatest commit: b371af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Run report for b371af50Total time: 12.5s | Comparison time: 11.9s | Estimated loss: 520.9ms (4.2% slower)
Touched files
|
... to sanitize the results so they don't directly reference the source data, which can break tests
…into cable/diff-generator-workshop
... i guess
* chore: added prettier & eslint moon tasks * chore: turned off caching for moon junk * chore: updated readme with repo and debug cli options * chore: updated lock file ... i guess * chore: more lock file chicanery
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of diff reporting to support additional output format, various bug fixes, and additional support stuff.
intended to be squashed, fyi
cli reporting can choose to output as markdown (and to a file)
adds additional command line options to better support git stuff
refactors update token detection code for clarity and debugging and whatnot
adds git workflows for comparing branches against s1, s2, and foundation data sets
adds some moon tasks for prettier and eslint checks
fixes some edge cases in the reporting that could cause a failure
fixes a token diff object tree traversal issue
fixes token diff object manipulation impacting downstream tests
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: