Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: max-visible-items does not work when breadcrumb items are added dynamically #4732

Open
1 task done
rickharris opened this issue Sep 9, 2024 · 0 comments
Open
1 task done

Comments

@rickharris
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-breadcrumbs

Expected behavior

When you render a breadcrumb that has less than max-visible-items breadcrumb items, and then adds more items, the breadcrumb should stop showing new breadcrumb items when it goes over max-visible-items.

Actual behavior

When you render a breadcrumb that has less than max-visible-items breadcrumb items, and then adds more items, all new breadcrumb items continue to be shown even if there are more than max-visible-items.

Screenshots

image

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

  1. Go to https://studio.webcomponents.dev/edit/3J5UCfXUj2WIngjxPlYI/src/index.ts?p=stories
  2. Click on "add breadcrumb item" multiple times
  3. After there are more than four items, notice that none of the breadcrumb items are hidden, they are all visible.

Sample code or abstract reproduction which illustrates the problem

https://studio.webcomponents.dev/edit/3J5UCfXUj2WIngjxPlYI/src/index.ts?p=stories

Severity

SEV 4

Logs taken while reproducing problem

No response

@rickharris rickharris added bug Something isn't working triage An issue needing triage needs jira ticket labels Sep 9, 2024
@najikahalsema najikahalsema removed the triage An issue needing triage label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants