Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't trigger change event on breadcrumbs via keyboard #4733

Closed
1 task done
rickharris opened this issue Sep 10, 2024 · 1 comment
Closed
1 task done

[Bug]: Can't trigger change event on breadcrumbs via keyboard #4733

rickharris opened this issue Sep 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working Component: Breadcrumb

Comments

@rickharris
Copy link
Contributor

rickharris commented Sep 10, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-breadcrumbs

Expected behavior

When focused on a breadcrumb item, I would expect that hitting enter (or possibly spacebar as well, though I'm not sure what the correct behavior for the sp-breadcrumb-item role would be) would trigger the change event on the sp-breadcrumbs element.

Actual behavior

The change event is only triggered on the sp-breadcrumbs element when a breadcrumb item is clicked, but not when pressing enter or spacebar while a breadcrumb item has focus.

Screenshots

Screen.Recording.2024-09-09.at.8.53.17.PM.mov

In this screen recording you can see that the change event is triggered when a breadcrumb item is clicked. After clicking through items, I focus a breadcrumb item and then press both enter and spacebar several times, and the event is not triggered.

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://studio.webcomponents.dev/edit/kmx7QJCb3pDgMh5caVtZ/src/index.ts?p=stories
  2. Click on a breadcrumb item to see the event handler working
  3. Focus on one of the breadcrumb items and press enter and spacebar
  4. No event is triggered for keyboard events

Sample code or abstract reproduction which illustrates the problem

https://studio.webcomponents.dev/edit/kmx7QJCb3pDgMh5caVtZ/src/index.ts?p=stories

Severity

SEV 3

I've labeled this as SEV 3, but it could possibly be a SEV 2 depending on accessibility standards. It doesn't seem possible to navigate via the breadcrumb without a mouse.

Logs taken while reproducing problem

No response

@rickharris rickharris added bug Something isn't working triage An issue needing triage needs jira ticket labels Sep 10, 2024
@Rocss Rocss self-assigned this Sep 18, 2024
@najikahalsema
Copy link
Collaborator

Fixed via #4769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Breadcrumb
Projects
None yet
Development

No branches or pull requests

3 participants