Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: menu opened stops page keyboard shortcuts from working #4786

Open
1 task done
mizgaionutalexandru opened this issue Sep 26, 2024 · 0 comments · May be fixed by #4793
Open
1 task done

[Bug]: menu opened stops page keyboard shortcuts from working #4786

mizgaionutalexandru opened this issue Sep 26, 2024 · 0 comments · May be fixed by #4793
Labels
bug Something isn't working Component: Menu triage An issue needing triage WIP

Comments

@mizgaionutalexandru
Copy link
Contributor

mizgaionutalexandru commented Sep 26, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Menu

Expected behavior

An opened sp-menu should allow application keyboard shortcuts.

Actual behavior

An opened sp-menu doesn't allow application keyboard shortcuts, stopping the propagation of almost all keydown events.

Screenshots

No response

What browsers are you seeing the problem in?

Safari, Chrome

How can we reproduce this issue?

  1. Go to the menu storybook
  2. Press "V" (a storybook keyboard shortcut), observe that nothing happens.
  3. Close the menu
  4. Press "V" again
  5. See that the keyboard shorcut now works.

Sample code or abstract reproduction which illustrates the problem

The problem seems to be related to the interaction between the menu and rovingTabIndex controller as per this PR: https://github.com/adobe/spectrum-web-components/pull/3780/files#r1661806320.

Severity

SEV 2

Logs taken while reproducing problem

No response

@mizgaionutalexandru mizgaionutalexandru added bug Something isn't working triage An issue needing triage needs jira ticket Component: Menu labels Sep 26, 2024
@TarunAdobe TarunAdobe linked a pull request Oct 1, 2024 that will close this issue
14 tasks
@TarunAdobe TarunAdobe linked a pull request Oct 1, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Menu triage An issue needing triage WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants