-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update spectrum CSS versions #3916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
spectrum-css
branch
from
January 3, 2024 15:26
6990409
to
d0e3eac
Compare
Westbrook
requested review from
najikahalsema,
pfulton,
Rajdeepc,
spdev3000,
blunteshwar and
TarunAdobe
January 3, 2024 15:39
Tachometer resultsChromeaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
button-group permalink
button permalink
card permalink
checkbox permalink
color-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
dialog permalink
divider permalink
dropzone permalink
field-group permalink
field-label permalink
help-text permalink
icon permalink
icons permalink
illustrated-message permalink
infield-button permalink
link permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
progress-circle permalink
quick-actions permalink
radio permalink
search permalink
sidenav permalink
slider permalink
split-button permalink
split-view permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
thumbnail permalink
toast permalink
tooltip permalink
top-nav permalink
tray permalink
underlay permalink
Firefoxaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
button-group permalink
button permalink
card permalink
checkbox permalink
color-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
dialog permalink
divider permalink
dropzone permalink
field-group permalink
field-label permalink
help-text permalink
icon permalink
icons permalink
illustrated-message permalink
infield-button permalink
link permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
progress-circle permalink
quick-actions permalink
radio permalink
search permalink
sidenav permalink
slider permalink
split-button permalink
split-view permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
thumbnail permalink
toast permalink
tooltip permalink
top-nav permalink
tray permalink
underlay permalink
|
najikahalsema
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take closer to the latest Spectrum CSS packages.
offset
for all Overlays from 6 to 0 so that they follow the defaultRelated issue(s)
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.