-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added eslint plugin import check on missing dependencies #4928
base: main
Are you sure you want to change the base?
Conversation
Branch preview |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 11947981002Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certain tests are failing. Once we rectify them I think we are good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check multiple things:
- It would be best if we applied the same rule across the entire project. Currently, this only applies to
./tools/*
, but we also have a root-leveleslintrc.json
file. - If we apply it globally, I’d say
projects/documentation
is safe to ignore. - This change will likely trigger numerous linting errors, which should be addressed within the scope of this PR.
- Can we check if switching to JS-based ESLint configs (instead of JSON) might better support the required changes? This would allow us to add more complex path/package-parsing logic if needed.
Description
Added
eslint-plugin-import
plugin to check for extraneous dependencies.Related issue(s)
@spectrum-web-components/styles@1.0.0
importing lit in several places, but doesn’t depend on it and is missinglit
as its direct dependencies causing compile errorsMotivation and context
How has this been tested?
Test case 1
yarn lint
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.