Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Make icons great again!! #4960

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: d4ecbeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TarunAdobe TarunAdobe force-pushed the ttomar/make-icons-great-again branch 2 times, most recently from a923199 to e2511e8 Compare November 27, 2024 11:12
Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12139011935

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 20 (60.0%) changed or added relevant lines in 4 files are covered.
  • 67 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 97.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/checkbox/src/Checkbox.ts 4 12 33.33%
Files with Coverage Reduction New Missed Lines %
packages/checkbox/src/Checkbox.ts 20 87.71%
packages/iconset/src/iconset-svg.ts 47 63.92%
Totals Coverage Status
Change from base Build 12031482906: -0.2%
Covered Lines: 32217
Relevant Lines: 32710

💛 - Coveralls

Copy link

github-actions bot commented Nov 27, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.98 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.844 kB 236.357 kB 🏆 236.758 kB
Scripts 61.441 kB 53.904 kB 🏆 54.182 kB
Stylesheet 54.346 kB 47.972 kB 🏆 48.127 kB
Document 6.24 kB 5.461 kB 🏆 5.468 kB
Font 126.844 kB 126.605 kB 🏆 126.633 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@TarunAdobe TarunAdobe force-pushed the ttomar/make-icons-great-again branch from e2511e8 to 14080bb Compare November 27, 2024 11:39
Copy link

github-actions bot commented Nov 27, 2024

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 96.32ms - 99.00ms - faster ✔
7% - 10%
7.49ms - 10.67ms
branch 653 kB 105.88ms - 107.60ms slower ❌
8% - 11%
7.49ms - 10.67ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 57.87ms - 59.61ms - faster ✔
1% - 5%
0.78ms - 2.81ms
branch 714 kB 60.02ms - 61.05ms slower ❌
1% - 5%
0.78ms - 2.81ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 78.39ms - 79.72ms - faster ✔
5% - 7%
4.14ms - 6.25ms
branch 770 kB 83.43ms - 85.06ms slower ❌
5% - 8%
4.14ms - 6.25ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 50.95ms - 52.55ms - faster ✔
4% - 8%
2.31ms - 4.72ms
branch 792 kB 54.36ms - 56.17ms slower ❌
4% - 9%
2.31ms - 4.72ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 145.96ms - 150.38ms - faster ✔
2% - 6%
3.47ms - 8.92ms
branch 914 kB 152.78ms - 155.96ms slower ❌
2% - 6%
3.47ms - 8.92ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 72.97ms - 74.55ms - faster ✔
5% - 8%
4.13ms - 6.58ms
branch 873 kB 78.18ms - 80.05ms slower ❌
6% - 9%
4.13ms - 6.58ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 71.43ms - 72.90ms - faster ✔
6% - 9%
4.27ms - 6.65ms
branch 872 kB 76.69ms - 78.56ms slower ❌
6% - 9%
4.27ms - 6.65ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1876.37ms - 1879.65ms - unsure 🔍
-0% - +0%
-4.05ms - +0.34ms
branch 1.05 MB 1878.41ms - 1881.32ms unsure 🔍
-0% - +0%
-0.34ms - +4.05ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1882.55ms - 1885.54ms - unsure 🔍
-0% - +0%
-1.10ms - +3.42ms
branch 1.04 MB 1881.18ms - 1884.58ms unsure 🔍
-0% - +0%
-3.42ms - +1.10ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 14.37ms - 14.69ms - faster ✔
1% - 4%
0.12ms - 0.54ms
branch 663 kB 14.72ms - 15.00ms slower ❌
1% - 4%
0.12ms - 0.54ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 110.22ms - 112.80ms - faster ✔
1% - 3%
0.65ms - 3.45ms
branch 697 kB 113.01ms - 114.11ms slower ❌
1% - 3%
0.65ms - 3.45ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 536.09ms - 546.04ms - faster ✔
2% - 4%
9.47ms - 22.35ms
branch 933 kB 552.89ms - 561.06ms slower ❌
2% - 4%
9.47ms - 22.35ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 48.33ms - 49.34ms - faster ✔
5% - 8%
2.83ms - 4.28ms
branch 689 kB 51.87ms - 52.91ms slower ❌
6% - 9%
2.83ms - 4.28ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 55.21ms - 56.29ms - faster ✔
5% - 7%
2.81ms - 4.38ms
branch 695 kB 58.77ms - 59.92ms slower ❌
5% - 8%
2.81ms - 4.38ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 41.35ms - 42.56ms - faster ✔
2% - 5%
0.83ms - 2.35ms
branch 744 kB 43.07ms - 44.01ms slower ❌
2% - 6%
0.83ms - 2.35ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 48.47ms - 49.81ms - faster ✔
2% - 6%
1.14ms - 3.13ms
branch 643 kB 50.54ms - 52.01ms slower ❌
2% - 6%
1.14ms - 3.13ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 94.02ms - 96.08ms - faster ✔
4% - 7%
4.21ms - 7.02ms
branch 863 kB 99.70ms - 101.62ms slower ❌
4% - 7%
4.21ms - 7.02ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 748 kB 46.25ms - 46.99ms - faster ✔
9% - 13%
4.77ms - 6.63ms
branch 757 kB 51.46ms - 53.17ms slower ❌
10% - 14%
4.77ms - 6.63ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 42.89ms - 43.47ms - faster ✔
1% - 3%
0.33ms - 1.35ms
branch 990 kB 43.61ms - 44.44ms slower ❌
1% - 3%
0.33ms - 1.35ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 404.09ms - 412.37ms - slower ❌
8% - 11%
28.64ms - 40.58ms
branch 991 kB 369.32ms - 377.92ms faster ✔
7% - 10%
28.64ms - 40.58ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 53.43ms - 54.57ms - faster ✔
7% - 9%
3.90ms - 5.49ms
branch 897 kB 58.14ms - 59.25ms slower ❌
7% - 10%
3.90ms - 5.49ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 82.60ms - 83.31ms - faster ✔
1% - 3%
1.12ms - 2.84ms
branch 758 kB 84.16ms - 85.72ms slower ❌
1% - 3%
1.12ms - 2.84ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 47.89ms - 48.82ms - faster ✔
6% - 8%
2.83ms - 4.28ms
branch 649 kB 51.36ms - 52.46ms slower ❌
6% - 9%
2.83ms - 4.28ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 22.97ms - 23.41ms - faster ✔
1% - 4%
0.34ms - 0.94ms
branch 626 kB 23.62ms - 24.05ms slower ❌
1% - 4%
0.34ms - 0.94ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 12.49ms - 13.03ms - faster ✔
1% - 6%
0.17ms - 0.79ms
branch 621 kB 13.10ms - 13.39ms slower ❌
1% - 6%
0.17ms - 0.79ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 15.66ms - 16.01ms - slower ❌
12% - 15%
1.67ms - 2.11ms
branch 627 kB 13.81ms - 14.08ms faster ✔
11% - 13%
1.67ms - 2.11ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 17.32ms - 17.72ms - faster ✔
7% - 13%
1.31ms - 2.61ms
branch 638 kB 18.86ms - 20.10ms slower ❌
7% - 15%
1.31ms - 2.61ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 221.62ms - 225.47ms - faster ✔
1% - 4%
2.82ms - 8.81ms
branch 710 kB 227.07ms - 231.65ms slower ❌
1% - 4%
2.82ms - 8.81ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 668 kB 51.34ms - 52.36ms - faster ✔
4% - 6%
1.91ms - 3.19ms
branch 642 kB 54.01ms - 54.79ms slower ❌
4% - 6%
1.91ms - 3.19ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 795 kB 76.79ms - 78.51ms - faster ✔
8% - 11%
7.16ms - 9.69ms
branch 800 kB 85.14ms - 87.01ms slower ❌
9% - 13%
7.16ms - 9.69ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 982 kB 439.69ms - 446.18ms - faster ✔
0% - 2%
0.18ms - 9.69ms
branch 938 kB 444.39ms - 451.35ms slower ❌
0% - 2%
0.18ms - 9.69ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 27.16ms - 27.99ms - faster ✔
4% - 8%
1.12ms - 2.34ms
branch 1.02 MB 28.85ms - 29.76ms slower ❌
4% - 9%
1.12ms - 2.34ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 361.51ms - 368.88ms - faster ✔
2% - 4%
6.31ms - 15.12ms
branch 1.01 MB 373.50ms - 378.31ms slower ❌
2% - 4%
6.31ms - 15.12ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 45.85ms - 46.80ms - faster ✔
7% - 10%
3.47ms - 4.93ms
branch 806 kB 49.96ms - 51.08ms slower ❌
7% - 11%
3.47ms - 4.93ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 32.37ms - 33.07ms - faster ✔
5% - 7%
1.58ms - 2.57ms
branch 649 kB 34.45ms - 35.14ms slower ❌
5% - 8%
1.58ms - 2.57ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 531.22ms - 540.08ms - faster ✔
1% - 4%
7.04ms - 21.11ms
branch 772 kB 544.26ms - 555.19ms slower ❌
1% - 4%
7.04ms - 21.11ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 108.46ms - 110.75ms - faster ✔
1% - 3%
0.56ms - 3.37ms
branch 773 kB 110.76ms - 112.37ms slower ❌
0% - 3%
0.56ms - 3.37ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 666 kB 30.73ms - 31.30ms - faster ✔
2% - 6%
0.79ms - 1.80ms
branch 641 kB 31.90ms - 32.73ms slower ❌
3% - 6%
0.79ms - 1.80ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 39.06ms - 40.00ms - faster ✔
1% - 4%
0.45ms - 1.67ms
branch 641 kB 40.20ms - 40.99ms slower ❌
1% - 4%
0.45ms - 1.67ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 43.89ms - 44.60ms - faster ✔
4% - 6%
1.67ms - 2.72ms
branch 743 kB 46.05ms - 46.82ms slower ❌
4% - 6%
1.67ms - 2.72ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 80.02ms - 82.07ms - faster ✔
4% - 7%
3.18ms - 5.75ms
branch 716 kB 84.73ms - 86.29ms slower ❌
4% - 7%
3.18ms - 5.75ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 16.02ms - 16.27ms - faster ✔
7% - 9%
1.18ms - 1.60ms
branch 644 kB 17.37ms - 17.70ms slower ❌
7% - 10%
1.18ms - 1.60ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 17.70ms - 18.08ms - faster ✔
3% - 6%
0.51ms - 1.11ms
branch 634 kB 18.47ms - 18.93ms slower ❌
3% - 6%
0.51ms - 1.11ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 129.25ms - 131.53ms - faster ✔
4% - 6%
5.73ms - 8.87ms
branch 740 kB 136.61ms - 138.76ms slower ❌
4% - 7%
5.73ms - 8.87ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 683 kB 119.73ms - 121.43ms - unsure 🔍
-2% - +0%
-1.93ms - +0.26ms
branch 660 kB 120.73ms - 122.10ms unsure 🔍
-0% - +2%
-0.26ms - +1.93ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 15.21ms - 15.49ms - unsure 🔍
-0% - +2%
-0.03ms - +0.33ms
branch 687 kB 15.08ms - 15.31ms unsure 🔍
-2% - +0%
-0.33ms - +0.03ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 693 kB 27.23ms - 27.77ms - faster ✔
6% - 9%
1.81ms - 2.62ms
branch 702 kB 29.41ms - 30.02ms slower ❌
7% - 10%
1.81ms - 2.62ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 696 kB 32.16ms - 33.25ms - faster ✔
7% - 12%
2.51ms - 4.38ms
branch 672 kB 35.39ms - 36.90ms slower ❌
8% - 13%
2.51ms - 4.38ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 874 kB 38.18ms - 38.73ms - faster ✔
3% - 5%
1.29ms - 2.12ms
branch 826 kB 39.85ms - 40.47ms slower ❌
3% - 6%
1.29ms - 2.12ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 27.15ms - 27.92ms - faster ✔
7% - 12%
2.23ms - 3.65ms
branch 787 kB 29.88ms - 31.07ms slower ❌
8% - 13%
2.23ms - 3.65ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 56.75ms - 57.74ms - faster ✔
5% - 7%
2.73ms - 4.18ms
branch 910 kB 60.17ms - 61.23ms slower ❌
5% - 7%
2.73ms - 4.18ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 46.64ms - 47.49ms - faster ✔
6% - 8%
2.80ms - 4.16ms
branch 885 kB 50.01ms - 51.07ms slower ❌
6% - 9%
2.80ms - 4.16ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 42.34ms - 44.03ms - faster ✔
3% - 7%
1.15ms - 3.13ms
branch 666 kB 44.81ms - 45.84ms slower ❌
3% - 7%
1.15ms - 3.13ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 65.65ms - 68.50ms - faster ✔
1% - 6%
0.86ms - 4.01ms
branch 763 kB 68.84ms - 70.18ms slower ❌
1% - 6%
0.86ms - 4.01ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 190.40ms - 198.60ms - faster ✔
7% - 13%
15.75ms - 27.77ms
branch 653 kB 211.87ms - 220.65ms slower ❌
8% - 14%
15.75ms - 27.77ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 119.82ms - 128.74ms - faster ✔
3% - 11%
3.20ms - 15.24ms
branch 714 kB 129.47ms - 137.53ms slower ❌
2% - 12%
3.20ms - 15.24ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 814 kB 170.91ms - 180.09ms - faster ✔
1% - 8%
1.41ms - 15.83ms
branch 770 kB 178.56ms - 189.68ms slower ❌
1% - 9%
1.41ms - 15.83ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 836 kB 116.94ms - 125.70ms - unsure 🔍
-7% - +3%
-8.90ms - +3.42ms
branch 792 kB 119.73ms - 128.39ms unsure 🔍
-3% - +7%
-3.42ms - +8.90ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 290.58ms - 293.74ms - faster ✔
16% - 17%
54.24ms - 60.92ms
branch 914 kB 346.80ms - 352.68ms slower ❌
19% - 21%
54.24ms - 60.92ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 158.01ms - 161.83ms - slower ❌
0% - 4%
0.52ms - 6.36ms
branch 873 kB 154.27ms - 158.69ms faster ✔
0% - 4%
0.52ms - 6.36ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 142.47ms - 147.49ms - faster ✔
0% - 5%
0.17ms - 7.87ms
branch 872 kB 146.08ms - 151.92ms slower ❌
0% - 5%
0.17ms - 7.87ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1897.36ms - 1906.52ms - unsure 🔍
-0% - +0%
-8.62ms - +2.90ms
branch 1.05 MB 1901.31ms - 1908.29ms unsure 🔍
-0% - +0%
-2.90ms - +8.62ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1903.28ms - 1906.88ms - faster ✔
0% - 1%
7.51ms - 15.93ms
branch 1.04 MB 1912.99ms - 1920.61ms slower ❌
0% - 1%
7.51ms - 15.93ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 30.02ms - 33.10ms - unsure 🔍
-9% - +4%
-3.09ms - +1.33ms
branch 663 kB 30.85ms - 34.03ms unsure 🔍
-4% - +10%
-1.33ms - +3.09ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 211.32ms - 222.16ms - unsure 🔍
-3% - +5%
-5.99ms - +10.03ms
branch 697 kB 208.82ms - 220.62ms unsure 🔍
-5% - +3%
-10.03ms - +5.99ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 860.09ms - 869.71ms - faster ✔
2% - 5%
17.10ms - 47.14ms
branch 933 kB 882.79ms - 911.25ms slower ❌
2% - 5%
17.10ms - 47.14ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 114.85ms - 123.03ms - unsure 🔍
-8% - +1%
-9.33ms - +1.61ms
branch 689 kB 119.16ms - 126.44ms unsure 🔍
-1% - +8%
-1.61ms - +9.33ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 125.53ms - 131.79ms - faster ✔
3% - 10%
3.29ms - 14.07ms
branch 695 kB 132.95ms - 141.73ms slower ❌
2% - 11%
3.29ms - 14.07ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 78.56ms - 84.88ms - faster ✔
0% - 12%
0.18ms - 10.30ms
branch 744 kB 83.01ms - 90.91ms slower ❌
0% - 13%
0.18ms - 10.30ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 110.47ms - 116.33ms - unsure 🔍
-6% - +2%
-7.07ms - +1.83ms
branch 643 kB 112.67ms - 119.37ms unsure 🔍
-2% - +6%
-1.83ms - +7.07ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 910 kB 206.49ms - 214.39ms - faster ✔
2% - 7%
4.26ms - 16.02ms
branch 863 kB 216.22ms - 224.94ms slower ❌
2% - 8%
4.26ms - 16.02ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 756 kB 86.38ms - 91.70ms - faster ✔
4% - 11%
3.38ms - 10.86ms
branch 765 kB 93.53ms - 98.79ms slower ❌
4% - 12%
3.38ms - 10.86ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 71.82ms - 73.70ms - faster ✔
3% - 8%
1.93ms - 5.83ms
branch 990 kB 74.93ms - 78.35ms slower ❌
3% - 8%
1.93ms - 5.83ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 779.13ms - 792.51ms - slower ❌
3% - 8%
25.15ms - 57.09ms
branch 991 kB 730.19ms - 759.21ms faster ✔
3% - 7%
25.15ms - 57.09ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 114.85ms - 121.19ms - faster ✔
1% - 9%
0.65ms - 10.71ms
branch 897 kB 119.79ms - 127.61ms slower ❌
0% - 9%
0.65ms - 10.71ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 129.21ms - 137.07ms - unsure 🔍
-6% - +2%
-8.07ms - +3.23ms
branch 758 kB 131.50ms - 139.62ms unsure 🔍
-2% - +6%
-3.23ms - +8.07ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 105.73ms - 116.87ms - unsure 🔍
-9% - +4%
-9.86ms - +4.94ms
branch 649 kB 108.88ms - 118.64ms unsure 🔍
-5% - +9%
-4.94ms - +9.86ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 55.93ms - 60.35ms - unsure 🔍
-11% - +1%
-7.16ms - +1.00ms
branch 626 kB 57.79ms - 64.65ms unsure 🔍
-2% - +12%
-1.00ms - +7.16ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 28.19ms - 30.13ms - unsure 🔍
-10% - +1%
-3.00ms - +0.28ms
branch 621 kB 29.19ms - 31.85ms unsure 🔍
-1% - +10%
-0.28ms - +3.00ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 651 kB 36.50ms - 40.14ms - slower ❌
10% - 25%
3.48ms - 8.04ms
branch 627 kB 31.19ms - 33.93ms faster ✔
10% - 20%
3.48ms - 8.04ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 44.30ms - 48.10ms - unsure 🔍
-6% - +5%
-2.91ms - +2.11ms
branch 638 kB 44.96ms - 48.24ms unsure 🔍
-5% - +6%
-2.11ms - +2.91ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 407.14ms - 421.90ms - unsure 🔍
-5% - +0%
-20.79ms - +0.67ms
branch 710 kB 416.79ms - 432.37ms unsure 🔍
-0% - +5%
-0.67ms - +20.79ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 668 kB 90.56ms - 96.60ms - unsure 🔍
-8% - +1%
-8.10ms - +1.02ms
branch 642 kB 93.70ms - 100.54ms unsure 🔍
-1% - +9%
-1.02ms - +8.10ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 795 kB 158.06ms - 165.82ms - faster ✔
7% - 13%
11.71ms - 22.73ms
branch 800 kB 175.25ms - 183.07ms slower ❌
7% - 14%
11.71ms - 22.73ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 699.26ms - 708.54ms - slower ❌
8% - 10%
52.60ms - 64.04ms
branch 1.01 MB 642.24ms - 648.92ms faster ✔
8% - 9%
52.60ms - 64.04ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 53.53ms - 54.27ms - faster ✔
3% - 5%
1.77ms - 3.07ms
branch 1.02 MB 55.79ms - 56.85ms slower ❌
3% - 6%
1.77ms - 3.07ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 703.16ms - 713.28ms - slower ❌
6% - 9%
39.91ms - 57.81ms
branch 1.01 MB 651.98ms - 666.74ms faster ✔
6% - 8%
39.91ms - 57.81ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 93.75ms - 98.45ms - faster ✔
5% - 12%
4.81ms - 12.39ms
branch 806 kB 101.72ms - 107.68ms slower ❌
5% - 13%
4.81ms - 12.39ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 674 kB 65.11ms - 70.17ms - unsure 🔍
-11% - -0%
-7.64ms - +0.00ms
branch 649 kB 68.60ms - 74.32ms unsure 🔍
-0% - +11%
-0.00ms - +7.64ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 1030.00ms - 1039.80ms - faster ✔
3% - 7%
34.04ms - 74.08ms
branch 772 kB 1069.55ms - 1108.37ms slower ❌
3% - 7%
34.04ms - 74.08ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 152.03ms - 163.25ms - unsure 🔍
-7% - +3%
-11.98ms - +4.26ms
branch 773 kB 155.63ms - 167.37ms unsure 🔍
-3% - +8%
-4.26ms - +11.98ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 666 kB 63.56ms - 68.52ms - unsure 🔍
-7% - +3%
-4.53ms - +1.85ms
branch 641 kB 65.37ms - 69.39ms unsure 🔍
-3% - +7%
-1.85ms - +4.53ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 80.38ms - 86.18ms - unsure 🔍
-5% - +4%
-4.03ms - +2.95ms
branch 641 kB 81.87ms - 85.77ms unsure 🔍
-4% - +5%
-2.95ms - +4.03ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 737 kB 89.32ms - 95.12ms - unsure 🔍
-7% - +1%
-6.90ms - +1.18ms
branch 743 kB 92.27ms - 97.89ms unsure 🔍
-1% - +8%
-1.18ms - +6.90ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 161.17ms - 169.79ms - unsure 🔍
-7% - +1%
-12.07ms - +1.15ms
branch 716 kB 165.93ms - 175.95ms unsure 🔍
-1% - +7%
-1.15ms - +12.07ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 35.98ms - 40.54ms - unsure 🔍
-12% - +3%
-4.73ms - +1.37ms
branch 644 kB 37.91ms - 41.97ms unsure 🔍
-4% - +13%
-1.37ms - +4.73ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 41.77ms - 45.75ms - unsure 🔍
-7% - +5%
-3.31ms - +2.27ms
branch 634 kB 42.32ms - 46.24ms unsure 🔍
-5% - +8%
-2.27ms - +3.31ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 802 kB 291.64ms - 299.32ms - faster ✔
2% - 7%
7.28ms - 21.72ms
branch 740 kB 303.86ms - 316.10ms slower ❌
2% - 7%
7.28ms - 21.72ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 683 kB 208.20ms - 220.44ms - unsure 🔍
-5% - +3%
-11.83ms - +6.27ms
branch 660 kB 210.43ms - 223.77ms unsure 🔍
-3% - +6%
-6.27ms - +11.83ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 712 kB 31.07ms - 34.01ms - unsure 🔍
-8% - +7%
-2.58ms - +2.18ms
branch 687 kB 30.87ms - 34.61ms unsure 🔍
-7% - +8%
-2.18ms - +2.58ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 693 kB 52.39ms - 55.97ms - faster ✔
8% - 18%
4.67ms - 11.21ms
branch 702 kB 59.38ms - 64.86ms slower ❌
8% - 21%
4.67ms - 11.21ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 696 kB 75.40ms - 82.48ms - unsure 🔍
-9% - +2%
-7.40ms - +1.80ms
branch 672 kB 78.80ms - 84.68ms unsure 🔍
-2% - +9%
-1.80ms - +7.40ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 92.35ms - 98.69ms - slower ❌
14% - 26%
11.86ms - 20.14ms
branch 909 kB 76.86ms - 82.18ms faster ✔
13% - 21%
11.86ms - 20.14ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 52.24ms - 53.76ms - faster ✔
1% - 4%
0.35ms - 2.25ms
branch 787 kB 53.73ms - 54.87ms slower ❌
1% - 4%
0.35ms - 2.25ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 153.40ms - 158.00ms - slower ❌
12% - 17%
16.32ms - 22.96ms
branch 910 kB 133.67ms - 138.45ms faster ✔
11% - 15%
16.32ms - 22.96ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 90.10ms - 94.14ms - faster ✔
28% - 33%
35.75ms - 45.09ms
branch 885 kB 128.33ms - 136.75ms slower ❌
38% - 49%
35.75ms - 45.09ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 101.36ms - 108.80ms - faster ✔
2% - 11%
2.01ms - 12.59ms
branch 666 kB 108.63ms - 116.13ms slower ❌
2% - 12%
2.01ms - 12.59ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 116.44ms - 123.24ms - unsure 🔍
-8% - +0%
-10.33ms - +0.41ms
branch 763 kB 120.64ms - 128.96ms unsure 🔍
-0% - +9%
-0.41ms - +10.33ms
-

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Nov 28, 2024

This is a good start but let's create a RFC on this first, we need to talk to the product teams also to make sure we are building for them and not for the component library. We can connect this PR to the RFC also.

@TarunAdobe TarunAdobe force-pushed the ttomar/make-icons-great-again branch from 14080bb to 1667aa7 Compare November 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants