Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme): remove spectrum-two beta warning #4975

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(theme): remove spectrum-two beta warning #4975

wants to merge 1 commit into from

Conversation

rubencarvalho
Copy link
Collaborator

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this

  • Test case 2

    1. Go here
    2. Do this

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 64cd63a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12180330660

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 98.187%
Totals Coverage Status
Change from base Build 12079841155: -0.004%
Covered Lines: 32385
Relevant Lines: 32805
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.169 kB 236.78 kB 236.744 kB 🏆
Scripts 61.087 kB 54.236 kB 54.175 kB 🏆
Stylesheet 53.853 kB 48.11 kB 48.082 kB 🏆
Document 6.224 kB 5.461 kB 🏆 5.514 kB
Font 126.988 kB 126.622 kB 🏆 126.624 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 54.11ms - 55.42ms - faster ✔
3% - 7%
1.82ms - 4.18ms
branch 716 kB 56.78ms - 58.75ms slower ❌
3% - 8%
1.82ms - 4.18ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 140.16ms - 143.16ms - faster ✔
4% - 7%
6.02ms - 10.23ms
branch 918 kB 148.31ms - 151.26ms slower ❌
4% - 7%
6.02ms - 10.23ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 70.44ms - 71.61ms - faster ✔
6% - 10%
4.94ms - 7.50ms
branch 875 kB 76.10ms - 78.38ms slower ❌
7% - 11%
4.94ms - 7.50ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 69.14ms - 70.19ms - faster ✔
6% - 8%
4.16ms - 5.80ms
branch 874 kB 74.02ms - 75.28ms slower ❌
6% - 8%
4.16ms - 5.80ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1874.10ms - 1876.99ms - unsure 🔍
-0% - -0%
-4.82ms - -0.54ms
branch 1.05 MB 1876.65ms - 1879.80ms unsure 🔍
+0% - +0%
+0.54ms - +4.82ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1879.40ms - 1882.71ms - unsure 🔍
-0% - +0%
-1.54ms - +2.91ms
branch 1.05 MB 1878.88ms - 1881.85ms unsure 🔍
-0% - +0%
-2.91ms - +1.54ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 522.07ms - 531.13ms - faster ✔
1% - 3%
7.46ms - 17.97ms
branch 937 kB 536.64ms - 541.98ms slower ❌
1% - 3%
7.46ms - 17.97ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 41.90ms - 42.26ms - faster ✔
2% - 3%
0.94ms - 1.50ms
branch 958 kB 43.09ms - 43.51ms slower ❌
2% - 4%
0.94ms - 1.50ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 396.62ms - 400.96ms - faster ✔
1% - 3%
2.80ms - 11.27ms
branch 959 kB 402.19ms - 409.46ms slower ❌
1% - 3%
2.80ms - 11.27ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 52.97ms - 54.88ms - faster ✔
5% - 9%
2.91ms - 5.30ms
branch 899 kB 57.31ms - 58.74ms slower ❌
5% - 10%
2.91ms - 5.30ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 213.04ms - 215.58ms - faster ✔
2% - 4%
4.70ms - 9.50ms
branch 718 kB 219.37ms - 223.45ms slower ❌
2% - 4%
4.70ms - 9.50ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 982 kB 431.35ms - 435.47ms - faster ✔
1% - 2%
3.58ms - 9.46ms
branch 940 kB 437.84ms - 442.03ms slower ❌
1% - 2%
3.58ms - 9.46ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 26.11ms - 26.62ms - faster ✔
5% - 8%
1.46ms - 2.24ms
branch 1.02 MB 27.93ms - 28.50ms slower ❌
6% - 9%
1.46ms - 2.24ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 353.31ms - 356.53ms - faster ✔
3% - 4%
9.60ms - 14.60ms
branch 1.01 MB 365.11ms - 368.93ms slower ❌
3% - 4%
9.60ms - 14.60ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 44.58ms - 45.52ms - faster ✔
7% - 9%
3.27ms - 4.60ms
branch 806 kB 48.51ms - 49.45ms slower ❌
7% - 10%
3.27ms - 4.60ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 508.18ms - 518.02ms - faster ✔
3% - 5%
15.73ms - 29.49ms
branch 776 kB 530.90ms - 540.52ms slower ❌
3% - 6%
15.73ms - 29.49ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 107.92ms - 108.76ms - faster ✔
2% - 3%
1.73ms - 3.83ms
branch 775 kB 110.15ms - 112.08ms slower ❌
2% - 4%
1.73ms - 3.83ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 78.01ms - 79.42ms - faster ✔
5% - 8%
4.36ms - 6.81ms
branch 718 kB 83.29ms - 85.30ms slower ❌
5% - 9%
4.36ms - 6.81ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 874 kB 35.74ms - 36.26ms - faster ✔
4% - 6%
1.48ms - 2.28ms
branch 832 kB 37.58ms - 38.19ms slower ❌
4% - 6%
1.48ms - 2.28ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.73ms - 26.44ms - faster ✔
5% - 8%
1.36ms - 2.31ms
branch 789 kB 27.61ms - 28.24ms slower ❌
5% - 9%
1.36ms - 2.31ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 53.49ms - 54.95ms - faster ✔
4% - 7%
2.36ms - 4.14ms
branch 912 kB 56.97ms - 57.97ms slower ❌
4% - 8%
2.36ms - 4.14ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 44.20ms - 45.11ms - faster ✔
5% - 8%
2.30ms - 3.62ms
branch 887 kB 47.15ms - 48.09ms slower ❌
5% - 8%
2.30ms - 3.62ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 63.34ms - 65.41ms - faster ✔
1% - 5%
0.87ms - 3.16ms
branch 763 kB 65.90ms - 66.88ms slower ❌
1% - 5%
0.87ms - 3.16ms		 -
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 121.02ms - 129.14ms - faster ✔
0% - 8%
0.07ms - 11.17ms
branch 716 kB 126.92ms - 134.48ms unsure 🔍
-0% - +9%
+0.07ms - +11.17ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 287.02ms - 290.26ms - faster ✔
15% - 17%
53.06ms - 59.46ms
branch 918 kB 342.14ms - 347.66ms slower ❌
18% - 21%
53.06ms - 59.46ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 159.38ms - 162.62ms - slower ❌
7% - 10%
10.32ms - 15.40ms
branch 875 kB 146.19ms - 150.09ms faster ✔
6% - 10%
10.32ms - 15.40ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 144.70ms - 154.22ms - unsure 🔍
-2% - +5%
-3.28ms - +7.80ms
branch 874 kB 144.36ms - 150.04ms unsure 🔍
-5% - +2%
-7.80ms - +3.28ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1895.59ms - 1903.41ms - faster ✔
1% - 1%
12.06ms - 24.26ms
branch 1.05 MB 1912.97ms - 1922.35ms slower ❌
1% - 1%
12.06ms - 24.26ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1898.36ms - 1902.48ms - unsure 🔍
-0% - +0%
-6.38ms - +0.06ms
branch 1.05 MB 1901.11ms - 1906.05ms unsure 🔍
-0% - +0%
-0.06ms - +6.38ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 851.69ms - 863.99ms - faster ✔
2% - 5%
18.52ms - 46.44ms
branch 937 kB 877.79ms - 902.85ms slower ❌
2% - 5%
18.52ms - 46.44ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 68.51ms - 73.77ms - slower ❌
1% - 9%
0.64ms - 6.04ms
branch 958 kB 67.19ms - 68.41ms faster ✔
1% - 8%
0.64ms - 6.04ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 742.06ms - 763.02ms - slower ❌
4% - 8%
26.53ms - 55.27ms
branch 959 kB 701.81ms - 721.47ms faster ✔
4% - 7%
26.53ms - 55.27ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 113.27ms - 120.17ms - unsure 🔍
-6% - +1%
-6.79ms - +1.15ms
branch 899 kB 117.57ms - 121.51ms unsure 🔍
-1% - +6%
-1.15ms - +6.79ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 400.08ms - 414.52ms - unsure 🔍
-4% - +1%
-18.22ms - +2.62ms
branch 718 kB 407.59ms - 422.61ms unsure 🔍
-1% - +4%
-2.62ms - +18.22ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 679.38ms - 689.46ms - slower ❌
7% - 9%
43.60ms - 55.20ms
branch 1.02 MB 632.15ms - 637.89ms faster ✔
6% - 8%
43.60ms - 55.20ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 52.60ms - 53.60ms - faster ✔
3% - 6%
1.63ms - 3.33ms
branch 1.02 MB 54.89ms - 56.27ms slower ❌
3% - 6%
1.63ms - 3.33ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 688.64ms - 697.00ms - slower ❌
6% - 8%
39.45ms - 54.03ms
branch 1.01 MB 640.11ms - 652.05ms faster ✔
6% - 8%
39.45ms - 54.03ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 94.34ms - 100.50ms - faster ✔
0% - 8%
0.39ms - 8.05ms
branch 806 kB 99.35ms - 103.93ms slower ❌
0% - 8%
0.39ms - 8.05ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 1001.42ms - 1011.38ms - faster ✔
5% - 8%
50.57ms - 88.75ms
branch 776 kB 1057.63ms - 1094.49ms slower ❌
5% - 9%
50.57ms - 88.75ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 148.08ms - 155.92ms - faster ✔
1% - 9%
1.81ms - 14.15ms
branch 775 kB 155.22ms - 164.74ms slower ❌
1% - 9%
1.81ms - 14.15ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 160.44ms - 170.24ms - unsure 🔍
-6% - +1%
-10.42ms - +1.54ms
branch 718 kB 166.35ms - 173.21ms unsure 🔍
-1% - +6%
-1.54ms - +10.42ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 88.20ms - 94.76ms - slower ❌
14% - 25%
10.69ms - 18.63ms
branch 911 kB 74.59ms - 79.05ms faster ✔
12% - 20%
10.69ms - 18.63ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 50.90ms - 52.30ms - faster ✔
1% - 4%
0.41ms - 2.23ms
branch 789 kB 52.33ms - 53.51ms slower ❌
1% - 4%
0.41ms - 2.23ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 151.73ms - 157.27ms - slower ❌
11% - 17%
15.53ms - 23.15ms
branch 912 kB 132.54ms - 137.78ms faster ✔
10% - 15%
15.53ms - 23.15ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 91.02ms - 95.42ms - faster ✔
26% - 33%
33.43ms - 44.33ms
branch 887 kB 127.12ms - 137.08ms slower ❌
35% - 48%
33.43ms - 44.33ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 112.61ms - 120.19ms - unsure 🔍
-6% - +2%
-7.60ms - +2.48ms
branch 763 kB 115.64ms - 122.28ms unsure 🔍
-2% - +7%
-2.48ms - +7.60ms		 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubencarvalho @coveralls