Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of libexpat with latest cc crate #212

Closed
wants to merge 3 commits into from

Conversation

uttarayan21
Copy link
Contributor

Changes in this pull request

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@uttarayan21 uttarayan21 changed the title feat: Use compile_intermediates from cc for compiling Fix compilation of libexpat with latest cc crate May 1, 2024
scouten-adobe added a commit that referenced this pull request Jul 7, 2024
Adapted from #212: don't move intermediate build products into versioned paths.
scouten-adobe added a commit that referenced this pull request Jul 7, 2024
Adapted from #212: don't move intermediate build products into versioned paths.
@scouten-adobe
Copy link
Member

@uttarayan21, thank you so much for this patch. I'm closing this PR, but your work has been reflected in three PRs that I merged today: #216, #217, and #221. I'll be releasing 1.8.0 in a few hours and I hope that will be useful for you.

@scouten-adobe
Copy link
Member

@uttarayan21 I've released version 1.8.0 of the crate which incorporates these changes. Please let me know if you find any remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants