MWPW-135656: refactor region selector and social links decoration (#1560

)

* trivial: Update LICENSE (#1558)

* refactor: decorate links logic

* hotfix

* improved decorate content logic on global-footer

---------

Co-authored-by: Chris Millar <cmillar@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

libs/blocks/global-footer/global-footer.js

@@ -71,17 +71,15 @@ class Footer {
 
     if (!this.body) return;
 
-    // TODO: revisit region picker and social links decoration logic
-    const regionAnchor = this.body.querySelector('.region-selector a');
-    if (regionAnchor?.href) {
-      regionAnchor.setAttribute('href', `${regionAnchor.getAttribute('href')}#_dnt#_dnb`);
-    }
-    const socialLinks = document.querySelectorAll('.social a');
-    socialLinks.forEach((socialLink) => {
-      socialLink.setAttribute('href', `${socialLink.getAttribute('href')}#_dnb`);
-    });
+    const [region, social] = ['.region-selector', '.social'].map((selector) => this.body.querySelector(selector));
+    const [regionParent, socialParent] = [region.parentElement, social.parentElement];
+    [regionParent, socialParent].forEach((parent) => parent.replaceChildren());
+
     decorateLinks(this.body);
 
+    regionParent.appendChild(region);
+    socialParent.appendChild(social);
+
     // Order is important, decorateFooter makes use of elements
     // which have already been created in previous steps
     const tasks = [