Milo Policy for PRs that break Production #1445
chrischrischris
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Wanted to let everyone know how we're going to handle any PR that breaks production:
Any PR that breaks prod will be immediately reverted. No trying to patch it / fix it with new PRs. It gets reverted and the author will need to re-open with the fix.
The reasons for this:
Also reminder - once you have approvals for your PR, if you add / modify the code it's a good idea to ask the reviewers for another pass. We could also re-enable the github option that removes all approvals whenever the PR code is changed. I'd much prefer not to do that but we may be forced to with the amount of PRs that Milo is getting.
Beta Was this translation helpful? Give feedback.
All reactions