Marquee block enhancements

[Axelcureno]

As a requirement for a particular page (Catalog), a new UI enhancement to the Marquee block should be built with the text "Includes:" along with a list of product mnemonic and titles.

The original idea was to expand this new UI on the Marquee block with a class name Catalog and the code location to be inside Milo repository but after reading some feedback it was decided to use a more generic name and instead use the name includes. The question now would be what is the best repo location for this change given that the Marquee block is one of the most popular blocks and even a small change like this could have a big impact. Also, I'm sure this may not be this first or last time that such a change is needed for a block like this.

Preview URL: https://main--cc--adobecom.hlx.page/products/catalog?milolibs=MWPW-139968--milo--axelcureno&martech=off
Initial PR (Closed): #1637

Curious to hear other's opinion.
Is this something that maybe other teams can use for their pages? Or does this look like something more specific for CC pages?
Should we use a different name?
Should we dynamically load JS and CSS for this use case? Or can this live within the Marquee block files.

[ryanmparrish]

Thanks for bringing up this discussion @Axelcureno - My initial thought is we should never have conditional logic based on content for a specific english string. That opens up too many issues w/ localization and is generally a bad practice to rely on '*magic' values.

If we can just use the variant (catalog) to determine this opt in layout and rely on a set order in content structure, I think we're ok to add it to the existing marquee. If this catalog row has wildly different placement depending on authoring, We may want to consider a different approach. Thinking quiz-marquee, that has x number of additional content rows that gets inserted below the main content. This may be easier to manage because we have determined row order and not just logic of (row has buttons?, find parents previous element) etc.

[Axelcureno]

Thanks for the feedback, given that it is likely this content will be used in other blocks (see example below), will first explore the possibility of doing this as a separate block and linking it to a parent block.
As a fallback alternative, will consider the option of going with content structure-based logic and loading the changes dynamically rather than inside the marquee JS/CSS.

[chrischrischris]

Do you think this "includes" content will want to be used outside of the marquee? If so, I think we may want to create a separate block for it, then figure out a way to re-use the code inside marquee. The advantage of this is the code would only be loaded in marquee when it's being used. Actually we should probably keep that code separate regardless.

[Axelcureno]

As a matter of fact yes, it will be used in other places, for example in the ultra wide plans merch card.

I like the idea of creating it as a separate block and linking it to another block. Is there any block doing something like this already?