TWP Milo Block

[3ch023]

Do we have already a TWP Milo Block?
If not do we plan for one? I need something simple for rendering 'See what's included' link and assigning it the behavior.

[VKniaz]

As part of this discussion, I suggest checking the TWP Milo tabs:

The document structure will look like:

You can check the link:
https://mwpw-136874--milo--vkniaz.hlx.page/drafts/vkniaziev/twp-tabs/twp-tabs

Please feel free to express any ideas.

[geri-w]

Thanks @VKniaz the Tab structure makes sense. Two things would like to see from an authoring efficiency perspective:

1. Would like to put the "tabs (twp)" block in a fragment, so it can be updated separate from the modal file itself.
2. Would like to use placeholders for the tab titles: "Individuals", "Business", and "Students and Teachers" so those can be shared across all the modals and be updated in one place if there is a change to those.

[npeltier]

well, i'd like us to step back a bit here, beside the fact that discussion is about having a TWP block:

1. correct me if i'm wrong, but Individual / Business / Students & teacher, localisation aside, will always be those tabs and in that order, even with placeholders proposed by Geri, the structure itself does not look like it's "needed"
2. active tab is depending on the offer in origin CTA, not sure we do need to author it

all this to say it looks like TWP content could be inferred from the offers at stake, and that we would just need TWP cards to be authored, as i think @vladen was proposing earlier

[vhargrave]

kind of agree with @npeltier about taking a step back on this.
@VKniaz how exactly are you thinking that card selection will work as well? That probably also needs to be part of this whole TWP solution right?

[3ch023]

In we assume the tabs are generated based on cards configured for this modal, we have several options on how Milo block could create the left part of the modal. See options below:

Option 1

Milo block creates:

<merch-twp>
    <merch-card>
    <merch-card>
    <merch-card>
    <merch-card>
    <merch-panel>
<merch-twp>

From the cards provided, merch-twp WC will generate Tabs in shadow DOM and handle tab switches and updates on the subscription panel and cards and tabs.
pros: simple consumption for consumer (even outside of milo)

Option 2

Milo block creates:

<merch-subscription-layout>
    <merch-card-tabs>
       <merch-card>
       <merch-card>
       <merch-card>
       <merch-card>
    </merch-card-tabs>
    <merch-panel>
<merch-subscription-layout>

pros: merch-subscription-layout can be reused in other modals

[vhargrave]

@3ch023 I think those are some decent ideas. What if you combined your approach with the current tab solution, that @VKniaz already started building?
So using milo tabs but with a new twp variant to get the right styles and then something like this as content of each tab. That way you're not creating a new tabbing pattern, but also having a clean form within each tab.

<merch-subscription-form>
     <merch-card>
     <merch-card>
     <merch-card>
     <merch-card>
<merch-subscription-form>