Commerce Modals: D2P, TWP, CRM

[3ch023]

With TWP modal being in active development (see test content and modal in action) we need to decide on block namings.

At the moment we have 3 types of modals. TWP, D2P and CRM (content rich modal). TWP and D2P modals have no structural differences and their content structure most likely be the same. CRM content is different.

Option 1

to have a separate block for each:

• 'twp-modal'
• 'd2p-modal'
• 'crm-modal'
  pros: content authors and dev's can immediately understand what kind of modal it is
  cons: either code duplication between twp and d2p blocks, or, if we have a common file, we will need to load 2 js files instead of one.

Option 2

• 'twp-d2p-modal'
• 'crm-modal'

Option 3

• 'merch-modal'
  with variations 'twp', 'd2p', 'crm'
  cons: higher impact in case the bug is introduced in the common block. bigger scope of validation on each change to block.

Please feel free to suggest more options.

[npeltier]

i'm all for option 3 :) (merch-modal instead of commerce-modal),

i'd say in overall debate centralisation vs duplication, where risk is to propagate problems in one click in case of centralisation, that if we do our testing job right (and it's easier to do so with less code), we should not be concerned.

to take one step in advance to @yesil, we could have commerce-modal and commerce-card-modal as CRM has no card, but i'm sure we could keep things simple

[npeltier]

[3ch023]

and then enable card collection promotion feature for free

this becomes a promo topic for which I would create a separate discussion.

one does not affect another, block will create whatever WCs set we decide on, but we need to decide on block amount & names

[yesil]

Just last week, I got the question for the block names after the demo, and I confirmed merch-twp, merch-d2p where the same code would be used behind the scene.
I'm ok to rename them, but I find it a bit late to change the block logic itself with fragments.
@npeltier any good reason to prefer <merch-modal><merch-card-collection></merch-card-collection></merch-modal> to the proposed merch-twp block above?
Assuming that fragments in merch-twp can be targeted with MEP with easily.

[Axelcureno]

Since this was already presented to GWP and they approved it, given the time constrains we have, I vote to keep it as it was presented in last week's demo. :)

[npeltier]

sure :)