Why would broken nala tests ever be ok?

[npeltier]

for some code bus cache reasons, i've recently got all nala tests to fail, and still summary was happily giving me a green tick.
I would expect any of those failures to stop it.
If there were was a good reason to ignore nala failures, then i guess i would not add run-nala label to my PR, right?

[skumar09]

for some code bus cache reasons, i've recently got all nala tests to fail, and still summary was happily giving me a green tick. I would expect any of those failures to stop it. If there were was a good reason to ignore nala failures, then i guess i would not add run-nala label to my PR, right?
@npeltier : This could be a defect, I will fix it

[npeltier]

thanks :) for reference, "only" 76 broken tests, but still green https://github.com/adobecom/milo/actions/runs/8819496966/job/24210845576?pr=2187

[skumar09]

thanks :) for reference, "only" 76 broken tests, but still green https://github.com/adobecom/milo/actions/runs/8819496966/job/24210845576?pr=2187
@npeltier Thanks for the info. (I guess, due to the Retry failed test count (2), the pipeline job is not exiting with fail status.) I am working on the fix.

[skumar09]

@npeltier : Thanks for noticing this issue. I have fixed the defect, now for any test failures, the run-nala job will be in failed status

[honstar]

@skumar09, for completeness sake, can you provide a reference to the PR/commit with the fix? Thx

[skumar09]

@honstar : PR Reference: adobecom/nala#337