Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skms integration "hello" 'hello' \hello #1300

Merged
merged 126 commits into from
Sep 19, 2023
Merged

Conversation

amauch-adobe
Copy link
Contributor

  • Adds auto-approved CMR integration on Milo releases for SKMS.
  • New GitHub action for merged pull requests against the production branch.

Resolves: MWPW-131002

Test URLs:

SKMS CI integration start
removed pull request flow
changed branch for testing
filled in the values for stage testing
temp stage pass
updated skms call
changed event type to pull request, updated logic to only run when merged, added summary variable from github context.
cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.
added missing curly brace
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace
fixing conflicts
Fixing JSON Parsing
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace

* fixing conflicts

fixing conflicts

* Fixing JSON Parsing

Fixing JSON Parsing
fixing missing quotes, cleaned up summary
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace

* fixing conflicts

fixing conflicts

* Fixing JSON Parsing

Fixing JSON Parsing

* fixing missing quotes, cleaned up summary

fixing missing quotes, cleaned up summary
debugging JSON Parsing
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace

* fixing conflicts

fixing conflicts

* Fixing JSON Parsing

Fixing JSON Parsing

* fixing missing quotes, cleaned up summary

fixing missing quotes, cleaned up summary

* debugging JSON Parsing

debugging JSON Parsing
debugging echos
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace

* fixing conflicts

fixing conflicts

* Fixing JSON Parsing

Fixing JSON Parsing

* fixing missing quotes, cleaned up summary

fixing missing quotes, cleaned up summary

* debugging JSON Parsing

debugging JSON Parsing

* debugging echos

debugging echos
removing line breaks for JSON Parsing
* SKMS CI integration start

SKMS CI integration start

* removed pull request flow

removed pull request flow

* changed branch for testing

changed branch for testing

* filled in the values for stage testing

filled in the values for stage testing

* temp stage pass

temp stage pass

* updated skms call

updated skms call

* Updated skms.yaml to pull request event

changed event type to pull request, updated logic to only run when merged, added summary variable from github context.

* cleaned up, formatted, updated condition

cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.

* added missing curly brace

added missing curly brace

* fixing conflicts

fixing conflicts

* Fixing JSON Parsing

Fixing JSON Parsing

* fixing missing quotes, cleaned up summary

fixing missing quotes, cleaned up summary

* debugging JSON Parsing

debugging JSON Parsing

* debugging echos

debugging echos

* removing line breaks for JSON Parsing

removing line breaks for JSON Parsing
added repo variable for change executor
Using Github environment variables
created separate step for summary
updated release parameter
attempting to fix multiline GitHub Env
renamed delimiter
fixing multi-line string
adding more sanitization
reverted str sanitization, using jq instead.
fixing jq add error
fixing the jq add command
reverting sanitization method
another small tweak
@amauch-adobe amauch-adobe added the trivial PR doesn't require E2E testing by a reviewer label Sep 19, 2023
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1300 (758ed2b) into skms-release-test (a70bff2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           skms-release-test    #1300      +/-   ##
=====================================================
- Coverage              96.23%   96.22%   -0.01%     
=====================================================
  Files                    136      136              
  Lines                  33254    33254              
=====================================================
- Hits                   32001    32000       -1     
- Misses                  1253     1254       +1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amauch-adobe amauch-adobe merged commit 532c16e into skms-release-test Sep 19, 2023
11 of 12 checks passed
@amauch-adobe amauch-adobe deleted the skms-integration branch September 19, 2023 22:34
@amauch-adobe amauch-adobe restored the skms-integration branch September 19, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant