Skms integration "hello" 'hello' \hello #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKMS CI integration start
removed pull request flow
changed branch for testing
filled in the values for stage testing
temp stage pass
updated skms call
changed event type to pull request, updated logic to only run when merged, added summary variable from github context.
cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions.
added missing curly brace
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace
fixing conflicts
Fixing JSON Parsing
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace * fixing conflicts fixing conflicts * Fixing JSON Parsing Fixing JSON Parsing
fixing missing quotes, cleaned up summary
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace * fixing conflicts fixing conflicts * Fixing JSON Parsing Fixing JSON Parsing * fixing missing quotes, cleaned up summary fixing missing quotes, cleaned up summary
debugging JSON Parsing
…nto skms-integration
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace * fixing conflicts fixing conflicts * Fixing JSON Parsing Fixing JSON Parsing * fixing missing quotes, cleaned up summary fixing missing quotes, cleaned up summary * debugging JSON Parsing debugging JSON Parsing
debugging echos
…nto skms-integration
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace * fixing conflicts fixing conflicts * Fixing JSON Parsing Fixing JSON Parsing * fixing missing quotes, cleaned up summary fixing missing quotes, cleaned up summary * debugging JSON Parsing debugging JSON Parsing * debugging echos debugging echos
removing line breaks for JSON Parsing
* SKMS CI integration start SKMS CI integration start * removed pull request flow removed pull request flow * changed branch for testing changed branch for testing * filled in the values for stage testing filled in the values for stage testing * temp stage pass temp stage pass * updated skms call updated skms call * Updated skms.yaml to pull request event changed event type to pull request, updated logic to only run when merged, added summary variable from github context. * cleaned up, formatted, updated condition cleaned up, formatted, updated condition so that if statement is not on shell but on github actions. * added missing curly brace added missing curly brace * fixing conflicts fixing conflicts * Fixing JSON Parsing Fixing JSON Parsing * fixing missing quotes, cleaned up summary fixing missing quotes, cleaned up summary * debugging JSON Parsing debugging JSON Parsing * debugging echos debugging echos * removing line breaks for JSON Parsing removing line breaks for JSON Parsing
Using Github environment variables
created separate step for summary
updated release parameter
attempting to fix multiline GitHub Env
renamed delimiter
…nto skms-integration
fixing multi-line string
adding more sanitization
…nto skms-integration
reverted str sanitization, using jq instead.
fixing jq add error
fixing the jq add command
reverting sanitization method
another small tweak
…nto skms-integration
sanitizer tweak
another tweak
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## skms-release-test #1305 +/- ##
==================================================
Coverage 96.23% 96.24%
==================================================
Files 136 136
Lines 33254 33254
==================================================
+ Hits 32001 32004 +3
+ Misses 1253 1250 -3 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-131002
Test URLs: