Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync gnav branch from main #1689

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Sync gnav branch from main #1689

merged 4 commits into from
Jan 3, 2024

Conversation

narcis-radu
Copy link
Contributor

No description provided.

rgclayton and others added 4 commits January 2, 2024 12:45
* Summarize changes in 50 characters or less

More detailed explanatory text. Wrap at 72 characters.

Resolves: MWPW-xxxx
See also: MWPW-xxxx, MWPW-xxxx

* Adding unit test. Addressing PR feedback.

---------

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* apply style updates

* do not add dark to quiet marquee by default

* additional :is usage
Added style for .has-class to set logical grid display
* MWPW-140273 highlight replace fragment

* getFileName function

* permissions test

* remove test comment

* make manifestId consistent

* fix unit tests

* add to unit test

* streamline addHighlightData

---------

Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>
@narcis-radu narcis-radu added the trivial PR doesn't require E2E testing by a reviewer label Jan 3, 2024
@narcis-radu narcis-radu self-assigned this Jan 3, 2024
Copy link
Contributor

aem-code-sync bot commented Jan 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@narcis-radu narcis-radu merged commit cb3a837 into gnav Jan 3, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants