[Release] Stage to Main #2129
Merged
[Release] Stage to Main #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Blainegunn
commented
Apr 9, 2024
Blainegunn
commented
- MWPW-144600 [Milo FF] ANALYTICS update for proper DOM tagging of Card block - current use case CC Batch 03a Firefly pages #2069
- mwpw-145710: load ims via param from old domain #2080
- MWPW-144683 Allow Article Header Without Category #2084
- Add a few files to the .hlxignore files #2087
* Ignore json files * Add a few files to the .hlxignore * Remove unused folder and file --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* mwpw-145710: load ims via param from old domain * Address PR feedback * Do not remove new line
… block - current use case CC Batch 03a Firefly pages (#2069) * initial commit * Fix linter issue * optional chaining on section const * additional conditional chaining --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* MWPW-144683 Allow Article Header Without Category * authored table fix * remove commented out img * update test --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Blainegunn
requested review from
meganthecoder,
JasonHowellSlavin,
Brandon32,
rgclayton and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
- Coverage 96.36% 96.35% -0.01%
==========================================
Files 165 165
Lines 43523 43534 +11
==========================================
+ Hits 41940 41947 +7
- Misses 1583 1587 +4 ☔ View full report in Codecov by Sentry. |
JackySun9
added
run-nala
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
JackySun9
approved these changes
Apr 10, 2024
mokimo
approved these changes
Apr 10, 2024
Blainegunn
added
the
Ready for Main
overmyheadandbody
approved these changes
Apr 10, 2024
Roycethan
approved these changes
Apr 10, 2024
NadiiaSokolova
approved these changes
Apr 10, 2024
sigadamvenkata
approved these changes
Apr 10, 2024
Dli3
approved these changes
Apr 10, 2024
|
@adobecom/homepage-sot can you provide the last sign off in order for this to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.