[Release] Stage to Main #2138
Merged
[Release] Stage to Main #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Blainegunn
commented
Apr 11, 2024
Blainegunn
commented
- Fix: Adding gray bg and making header bold for group link on gnav #2131
- (Must be merged first thing April 15, IST time)
- MWPW-143904-Unit test and small authoring update for mobile-app-banner #2126
- fix(MWPW-142926):video modal does not close when esc button is pressed. #1925
- MWPW-143314: lana logs for feds-regionpicker.js 404s #2028
- MWPW-145591: Enable dom monitoring hook to verify javascript execution #2130
- MWPW-146268 - [Milo - Tabs] Pill dark/light support #2132
#2126) * Update-authoring * add unit test * Update mobile-app-banner.test.js * lint fix * incorporate review comments
…d. (#1925) * close dialog modal which contains only video on pressing esc * focus is set to close button insdie a video modal * fixed single qoute linting error * removed || false * hidden anchors should not be a part of the focusable elements * Update modal.js --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* added lana log for block load fail * fixed failing unit tests * log for missing modal class on region picker * added TODO * added log after trying to load modal block from region picker
#2130) * MWPW-145591: Dom monitoring hook * Lint
remove background unset on tab pill variant
Blainegunn
added
run-nala
Blainegunn
requested review from
ryanmparrish,
overmyheadandbody,
mokimo,
narcis-radu and
a team
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 96.38% 96.36% -0.02%
==========================================
Files 165 166 +1
Lines 43561 43645 +84
==========================================
+ Hits 41985 42058 +73
- Misses 1576 1587 +11 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
sigadamvenkata
approved these changes
Apr 12, 2024
mokimo
approved these changes
Apr 12, 2024
fullcolorcoder
approved these changes
Apr 12, 2024
TsayAdobe
approved these changes
Apr 12, 2024
Provides options to sync stage-to-stage or main-to-main sycn between repos
Dli3
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.