Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2340

Merged
merged 6 commits into from
May 21, 2024
Merged

[Release] Stage to Main #2340

merged 6 commits into from
May 21, 2024

Conversation

sharath-kannan and others added 2 commits May 21, 2024 06:36
update stage and prod PEP segments for photoshop and firefly
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented May 21, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner May 21, 2024 06:36
Copy link
Contributor

aem-code-sync bot commented May 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented May 21, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 95.09202% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 95.61%. Comparing base (18c77ef) to head (03efb0b).

Files Patch % Lines
libs/utils/utils.js 91.13% 7 Missing ⚠️
libs/features/jarvis-chat.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2340      +/-   ##
==========================================
+ Coverage   95.57%   95.61%   +0.03%     
==========================================
  Files         173      172       -1     
  Lines       45088    45110      +22     
==========================================
+ Hits        43094    43130      +36     
+ Misses       1994     1980      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…get (#2315)

* initial publish

* add lowercase to targetMd

* try consolidating metadata & enabled

* switch target and promo enabled

* update to getEnablement

* clean up config. merge config if also pzn

* remove some comments, fix some unit tests

* update handleCommands call from gnav utilities

* some unit test repair

* remove unused var

* improve getEnablement

* Update libs/features/personalization/personalization.js

Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* stash

* unit test repair

* lint issue

* move spoofParams to external file

* move mep param split

* lint issue

* unit test repair

* update mepParam spit logic

* change mepParam check

* remove unneeded check

* add default for existing in consolidateObjects

* revert which item on array is used in unit test

* add fallback if no commands

* add more unit tests

* remove spoofParams

---------

Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label May 21, 2024
@JackySun9 JackySun9 requested review from a team May 21, 2024 15:29
@JackySun9 JackySun9 added the needs-verification PR requires E2E testing by a reviewer label May 21, 2024
* Add africa to ZA mapping for jarvis

* Unit tests for MWPW-148640: jarvis africa to ZA mapping

* Unit tests for MWPW-148640: jarvis africa to ZA mapping
@tedAir tedAir self-requested a review May 21, 2024 17:00
MWPW-149356 - Fix for content disappearing before redirect

* bug fix for content flicker before redirect
* bug fix for debug mode where you cannot continue more than once

Resolves: [MWPW-149356](https://jira.corp.adobe.com/browse/MWPW-149356)

**Test URLs:**
- Before: https://main--milo--adobecom.hlx.page/?martech=off
- After: https://<branch>--milo--adobecom.hlx.page/?martech=off
@Blainegunn Blainegunn merged commit bbdd381 into main May 21, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BAcom SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 needs-verification PR requires E2E testing by a reviewer run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.