-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-154480 Split global-navigation.test.js into multiple files #2576
Conversation
Brings total time to run tests from 40s -> 19s on my machine.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2576 +/- ##
==========================================
+ Coverage 95.84% 96.28% +0.44%
==========================================
Files 176 176
Lines 46149 46149
==========================================
+ Hits 44230 44435 +205
+ Misses 1919 1714 -205 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hparra I have no idea how/why that would happen. Not going to complain though 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, as the tests can't run in parallel otherwise, thanks for tackling this! The global-navigation tests always lagged behind all the other completions locally
Error merging 2576: MWPW-154480 Split global-navigation.test.js into multiple files SLACK.merge(...).catch is not a function |
Brings total time to run tests from 40s -> 19s on my machine.
There are no code changes in this PR, only moving of code from global-navigation.test.js into multiple test files.
Unfortunately it does not speed up the running of the unit tests on the PR runs.
Resolves: MWPW-154480
Test URLs: