Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154480 Split global-navigation.test.js into multiple files #2576

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

chrischrischris
Copy link
Contributor

@chrischrischris chrischrischris commented Jul 16, 2024

Brings total time to run tests from 40s -> 19s on my machine.

There are no code changes in this PR, only moving of code from global-navigation.test.js into multiple test files.

Unfortunately it does not speed up the running of the unit tests on the PR runs.

Resolves: MWPW-154480

Test URLs:

Brings total time to run tests from 40s -> 19s on my machine.
@chrischrischris chrischrischris added the trivial PR doesn't require E2E testing by a reviewer label Jul 16, 2024
Copy link
Contributor

aem-code-sync bot commented Jul 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (d932b35) to head (f1984d2).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2576      +/-   ##
==========================================
+ Coverage   95.84%   96.28%   +0.44%     
==========================================
  Files         176      176              
  Lines       46149    46149              
==========================================
+ Hits        44230    44435     +205     
+ Misses       1919     1714     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Jul 16, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@hparra hparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an increase in coverage 🧐

Screenshot 2024-07-16 at 14 41 30

@chrischrischris
Copy link
Contributor Author

@hparra I have no idea how/why that would happen. Not going to complain though 😆

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, as the tests can't run in parallel otherwise, thanks for tackling this! The global-navigation tests always lagged behind all the other completions locally

@milo-pr-merge milo-pr-merge bot merged commit 448f98f into stage Jul 17, 2024
20 checks passed
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jul 17, 2024

Error merging 2576: MWPW-154480 Split global-navigation.test.js into multiple files SLACK.merge(...).catch is not a function

@milo-pr-merge milo-pr-merge bot deleted the split-gnav-tests branch July 17, 2024 10:12
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants