Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2602

Merged
merged 7 commits into from
Jul 23, 2024
Merged

[Release] Stage to Main #2602

merged 7 commits into from
Jul 23, 2024

Commits on Jul 22, 2024

  1. Mwpw-147034: Custom border color + badge/border color decoupling [Mer… 

    …ch card] (#2499)

MWPW-147907: Allow for 24pt font size for price [Merch Card]
    @Axelcureno
    Axelcureno authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c8ea741 View commit details
    Browse the repository at this point in the history

  2. MWPW-151863 - 🆕 Notification Block (#2557) 

    * banner notifications v1

remove console log

update grid classnames

change default size and remove cruft

add border decorator, opts system

ribbon notification beta, js cleanup

ribbon styles, add close button

extend button decoration, make responsive

normalize btn variants, handle center ribbon

base pill styles and banner pad tweak

fix btn sizing, other tweaks

center align action area buttons

updated ribbon styles based on feedback

update to close handling

style tweaks based on feedback

additional updates based on consonant feedback

update spacing for ribbon space between

i18n for css rules

tweaks to space between ribbon

add tests

* fix word wrap on pills, max width on banners

* updates based on feedback

* js cleanup
    @elan-tbx
    elan-tbx authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2dbd04c View commit details
    Browse the repository at this point in the history

  3. [MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation ( 

    #2567)

* initial commit

* initial commit

* initial commit

* final changes

* final changes

* increased code coverage

* review changes

* alloy test case

* added catch statement

* error type

---------

Co-authored-by: Drashti Modasara <drashti@drashtis-mbp.corp.adobe.com>
Co-authored-by: Drashti Modasara <drashti@Drashtis-MacBook-Pro.local>
Co-authored-by: Drashti Modasara <drashti@drashtis-mbp.macromedia.com>
    @drashti1712
    4 people authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6943446 View commit details
    Browse the repository at this point in the history

  4. MWPW-154057 social share destination links has '#_blank' added at end… 

    … of url for few locales (#2579)

Fixed the issue where social links were broken on some pages
    @sharmrj
    sharmrj authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8c5b0ac View commit details
    Browse the repository at this point in the history

  5. [Modal] Dedup Ongoing Dialogs for Same Fragment (#2594) 

    * dedup ongoing dialog

* Update libs/blocks/modal/modal.js

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

---------

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
    @JingleH @mokimo
    JingleH and mokimo authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0f3f4b8 View commit details
    Browse the repository at this point in the history

  6. MWPW-154599: Upgrade WTR & switch to playwright from puppeteer (#2590) 

    * Upgrade web test runner and switch to playwright from puppeteer

* re-enable skipped tabs test

* Use sinons faketimers for bulk v2 tests
    @mokimo
    mokimo authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    526a124 View commit details
    Browse the repository at this point in the history

  7. MWPW-141599: Fixes Card Title Accessibility Level (#2589) 

    MWPW-141599: Fixes Card Accessibility Title Level

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
    @cmiqueo @milo-pr-merge
    cmiqueo and milo-pr-merge[bot] authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    58a1fdf View commit details
    Browse the repository at this point in the history