Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2617

Merged
merged 5 commits into from
Jul 25, 2024
Merged

[Release] Stage to Main #2617

merged 5 commits into from
Jul 25, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Jul 24, 2024 •
edited by mokimo
Loading

Reverted

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

@bandana147
Bootstrapper script for milo feds blocks (#2560)
4531781 
* Adding feds block bootstraper for non milo

* Added css to load footer

* added css to load footer

* Updating default branch to main

* Taking configs and params and not making it iife

* Lint fix

* Adding configurable env names

* Lint fix

* Adding origin from milo config for non milo consumers

* Line fix

* Fixing code

* Adding support for privacy

* Adding support for federated urls in fragments block to centralisation

* Dynamic importing federated file and including test case

* Fix to accomodate gnav component from same script

* Fix for eslint

* Add test case for navigation js

* lint fix

* Adding support for localize link in region picker

* Add test case for bootstrapper js

---------

Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jul 24, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jul 24, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jul 24, 2024 •
edited
Loading

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@markpadbe @vgoodric
MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by…
c5fcc8e 
… Target for analytics and MWPW-152274 (#2593)

* replace overridePersonalizationVariant function

* Fix chaining

* Move parseMepParam

* add additional optional chaining operator

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

* Refactor personalization.js

* Remove comment

* Add TargetManifestId

* Remove comment

* Add targetManifestId test

* Refactor addMepHighlightAndTargetManifestIdGnav

* Remove console.log from test

* Shorten function name

* Limits targetManifestId to target exp and adds missing name to  manifestId

* Fix test

* Handle default selectedVariant issue

* Mostly done

* Merging in prop display update

* Unit tests fixed

* Add targetmanifestid to useblockcode

* refactor to remove unnecessary import

* Remove commented code

* Removing unused functions

* Update tests, not including replacePage

* Shorten Function Name

* move insert inline back to fragment.js

* additional cleanup and unit tests

* Fix adobeTargetTestId issues

* add optional chaining

* Update condition for addAnalyticsForUseBlockCode

* Refactor to handle analytics for updatemetadata

* Fix useBlockCode test

* Fix merged merged test

* Remove applyPers from preload fragments test

* Fix martech init post-merge

* Fix tests and martech merge cleanup

* Dynamically import personalization.js

* add 2 ignore comments

* add conditional chaining

* Remove mwpw-146528 temp files

* MWPW-152275 Move manifest.json request up while waiting on sstats / etc. (#2608)

* add preload

* shorten if and and conditional chaining

* run loop even if Target is off

* Add nullish coalescing assignment suggestion

* MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (#2616)

* add default execution order

* unit test

---------

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: vgoodric <vgoodric@adobe.com>
@bandana147
Fix for errors in dynamically loaded scripts in test cases (#2619)
0569bfd 
* Fix for dynamic script loading in test cases

* Lint fix
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (3afac8d) to head (c0395ae).
Report is 25 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
- Coverage   95.69%   95.69%   -0.01%     
==========================================
  Files         169      172       +3     
  Lines       45295    45359      +64     
==========================================
+ Hits        43345    43406      +61     
- Misses       1950     1953       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischrischris @overmyheadandbody
MWPW-128600 Locale Tool: Langstore points to langstore/en (#2615)
543d9a8 
* MWPW-128600 Langstore points to langstore/en

* Update libs/blocks/locale-nav/locale-nav.js

Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>

---------

Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Jul 24, 2024
@Dli3 Dli3 self-requested a review July 24, 2024 21:26
@tedAir tedAir self-requested a review July 24, 2024 22:19
@salonijain3
Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content ch…
c0395ae 
…anged by Target for analytics and MWPW-152274" (#2627)

Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by…"

This reverts commit c5fcc8e.
@milo-pr-merge milo-pr-merge bot merged commit f551e5b into main Jul 25, 2024
16 checks passed
mokimo added a commit that referenced this pull request Nov 13, 2024
@milo-pr-merge @Deva309
@vgoodric @markpadbe @ivanvatadobe @rahulgupta999 @rohitsahu @cmiqueo @mokimo @Blainegunn @denlight @overmyheadandbody @akanshaa-18 @robert-bogos @ryanmparrish @narcis-radu
Squashed commit of the following:
7c7a08e 
commit ee9d4a1
Merge: 668448b 9b05053
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Oct 3 17:13:53 2024 +0000

    [Release] Stage to Main (#2990)

commit 668448b
Merge: 23e81de d9ab9a2
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Oct 1 08:04:45 2024 +0000

    [Release] Stage to Main (#2980)

commit 23e81de
Merge: 4e0704d 4bc2230
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Sep 30 08:10:09 2024 +0000

    [Release] Stage to Main (#2965)

commit 4e0704d
Merge: 3d3a739 501a373
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Sep 26 14:40:26 2024 +0000

    [Release] Stage to Main (#2951)

commit 3d3a739
Merge: 7c2d611 5ddeb73
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Sep 25 08:32:27 2024 +0000

    [Release] Stage to Main (#2943)

commit 7c2d611
Merge: 132d69f b600045
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Sep 24 08:47:25 2024 +0000

    [Release] Stage to Main (#2910)

commit 132d69f
Merge: fb228f1 54c3cc0
Author: Blaine Gunn <Blainegunn@gmail.com>
Date:   Wed Sep 18 15:54:02 2024 -0600

    [Release] Stage to Main (#2898)

commit fb228f1
Author: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Date:   Wed Sep 18 12:37:01 2024 +0200

    Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

    Revert "MWPW-156749: Fix video CLS  (#2849)"

    This reverts commit d4134c8.

commit cc08e6e
Merge: d4cb64b 9323f28
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Sep 18 09:16:27 2024 +0000

    [Release] Stage to Main (#2893)

commit d4cb64b
Merge: b60741a 840e037
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Sep 17 09:15:15 2024 +0000

    [Release] Stage to Main (#2879)

commit b60741a
Merge: a35fcb3 6fa9558
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Sep 16 08:52:26 2024 +0000

    [Release] Stage to Main (#2874)

commit a35fcb3
Merge: c7a5d14 3679fd0
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Sep 12 17:00:11 2024 +0000

    [Release] Stage to Main (#2868)

commit c7a5d14
Merge: 28a75e5 3fd877c
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Sep 11 09:15:46 2024 +0000

    [Release] Stage to Main (#2859)

commit 28a75e5
Merge: c8d526f 2802011
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Sep 10 09:16:08 2024 +0000

    [Release] Stage to Main (#2852)

commit c8d526f
Merge: 95fb526 99a0fd7
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Sep 9 16:08:50 2024 +0000

    [Release] Stage to Main (#2842)

commit 95fb526
Merge: 91afbee 264c998
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Sep 5 16:45:17 2024 +0000

    [Release] Stage to Main (#2821)

commit 91afbee
Merge: eeddca4 7216452
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Sep 3 18:07:49 2024 +0000

    [Release] Stage to Main (#2811)

commit eeddca4
Merge: c06c15d 6012fcb
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Sep 2 08:16:45 2024 +0000

    [Release] Stage to Main (#2775)

commit c06c15d
Merge: 7dbef3a 2abe70f
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Aug 21 18:20:05 2024 +0000

    [Release] Stage to Main (#2766)

commit 7dbef3a
Merge: 53f37de dad8c45
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Aug 20 18:10:09 2024 +0000

    [Release] Stage to Main (#2756)

commit 53f37de
Merge: baef0d5 f92f07c
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Aug 19 08:12:17 2024 +0000

    [Release] Stage to Main (#2742)

commit baef0d5
Merge: 0b80fa1 302e9be
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Aug 14 08:19:13 2024 +0000

    [Release] Stage to Main (#2734)

commit 0b80fa1
Merge: 3abbe4d 60cb005
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Aug 13 16:08:05 2024 +0000

    [Release] Stage to Main (#2722)

commit 3abbe4d
Merge: 833abd4 7b9c7cf
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Aug 12 09:15:18 2024 +0000

    [Release] Stage to Main (#2716)

commit 833abd4
Merge: 5401829 ccb9704
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Aug 8 20:04:32 2024 +0000

    [Release] Stage to Main (#2701)

commit 5401829
Merge: 498b7c8 6418e29
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Aug 7 09:03:07 2024 +0000

    [Release] Stage to Main (#2697)

commit 498b7c8
Merge: 8f6bc8f 94b5b91
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Aug 6 16:51:41 2024 +0000

    [Release] Stage to Main (#2688)

commit 8f6bc8f
Merge: c3371ce 071a858
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Aug 5 09:14:21 2024 +0000

    [Release] Stage to Main (#2666)

commit c3371ce
Merge: 0073337 8232146
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jul 31 08:59:04 2024 +0000

    [Release] Stage to Main (#2648)

commit 0073337
Merge: 5028ef5 c00c777
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jul 30 08:13:26 2024 +0000

    [Release] Stage to Main (#2641)

commit 5028ef5
Merge: f551e5b add9745
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jul 29 08:22:11 2024 +0000

    [Release] Stage to Main (#2629)

commit f551e5b
Merge: e89908c c0395ae
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jul 25 09:15:40 2024 +0000

    [Release] Stage to Main (#2617)

commit e89908c
Merge: 3365940 3afac8d
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jul 24 08:06:01 2024 +0000

    [Release] Stage to Main (#2609)

commit 3365940
Merge: 61f8c81 58a1fdf
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jul 23 09:14:47 2024 +0000

    [Release] Stage to Main (#2602)

commit 61f8c81
Merge: 4e99424 31c21e8
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jul 22 15:11:42 2024 +0000

    [Release] Stage to Main (#2592)

commit 4e99424
Merge: 04e211c 0aa18e7
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jul 18 17:07:37 2024 +0000

    [Release] Stage to Main (#2580)

commit 04e211c
Merge: bc210e6 ba623c3
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jul 17 10:12:25 2024 +0000

    [Release] Stage to Main (#2571)

commit bc210e6
Merge: 830f7e1 fc03376
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jul 16 09:15:42 2024 +0000

    [Release] Stage to Main (#2568)

commit 830f7e1
Merge: 88577c7 c896518
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jul 15 09:15:20 2024 +0000

    [Release] Stage to Main (#2556)

commit 88577c7
Merge: 862fdab a77e493
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jul 10 17:58:39 2024 +0000

    [Release] Stage to Main (#2540)

commit 862fdab
Merge: 2217784 f5b5121
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jul 8 09:15:20 2024 +0000

    [Release] Stage to Main (#2528)

commit 2217784
Merge: 32f61f0 5e2dd4c
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jun 27 09:14:10 2024 +0000

    [Release] Stage to Main (#2520)

commit 32f61f0
Merge: 03578fb 75d922e
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jun 26 09:15:54 2024 +0000

    [Release] Stage to Main (#2515)

commit 03578fb
Merge: 47aaef0 1a8acc6
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jun 25 09:14:17 2024 +0000

    [Release] Stage to Main (#2503)

commit 47aaef0
Merge: f6fc4bf 5ad4b21
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jun 24 09:07:58 2024 +0000

    [Release] Stage to Main (#2495)

commit f6fc4bf
Merge: 02bf1a6 75fe20d
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jun 20 09:14:59 2024 +0000

    [Release] Stage to Main (#2489)

commit 02bf1a6
Merge: ddbdf7a 0428594
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jun 19 14:23:57 2024 +0000

    [Release] Stage to Main (#2482)

commit ddbdf7a
Merge: ead382f 16c64e4
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jun 18 10:37:30 2024 +0000

    [Release] Stage to Main (#2479)

commit ead382f
Merge: 931fa67 0cdd84a
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jun 17 09:14:39 2024 +0000

    [Release] Stage to Main (#2472)

commit 931fa67
Merge: 2350bd0 3d61c97
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jun 13 16:08:16 2024 +0000

    [Release] Stage to Main (#2470)

commit 2350bd0
Merge: e8300af 5a932b9
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jun 12 11:40:48 2024 +0000

    [Release] Stage to Main (#2462)

commit e8300af
Merge: 81d0085 f5e66e0
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jun 11 19:11:02 2024 +0000

    [Release] Stage to Main (#2447)

commit 81d0085
Merge: e5bff30 ca8ba03
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jun 10 09:15:44 2024 +0000

    [Release] Stage to Main (#2432)

commit e5bff30
Merge: b07f1a5 95a6593
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Thu Jun 6 09:15:01 2024 +0000

    [Release] Stage to Main (#2423)

commit b07f1a5
Merge: d9af238 fe0adb4
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Wed Jun 5 09:02:44 2024 +0000

    [Release] Stage to Main (#2414)

commit d9af238
Merge: be90c7d a60b132
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Tue Jun 4 10:34:02 2024 +0000

    [Release] Stage to Main (#2409)

commit be90c7d
Merge: b8b1871 0c0a36b
Author: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Date:   Mon Jun 3 15:20:01 2024 +0000

    [Release] Stage to Main (#2359)
[Release] Stage to Main (#3181)

* [MWPW-160011] - GNAV light mode color changes (#3019)

* Color changes

* Promo background color fix

* Add text and subtext font color changes in megamenu

* cross cloud menu background color changes

* Fix reveiew comments

* colors hexcode formatted as lowercase for css variables

* Bug fix MWPW-161889

* MWPW-161590, 161606, 161871, 161987 [MEP] Update placeholders before updating href (#3142)

* MWPW-161590 [MEP] Update placeholders before updating href

* unit test updates

* MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161)

* stash

* ready to publish

* interact call coming back but timing out

* working on a fast connection

* clean up ifs

* working with promise

* use camel case on let variable

* unit tests

* update unit tests

* MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047)

* create mepxlg branch

* update library

* require full hostname match

* update reference for unit test

* switch to use config instead of domain list and stub response in unit test

* update fetch to 2

* updating another fetch to 2

* restore normalizePath to use preview domains on preview links

* preload segment list json

* use getFederatedUrl instead

* import at top so we don't have to make normalizePath async

* MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064)

* add federated link function to registerInBlockActions

* add to unit test

* add unit test coverage

* initial commit

* Fix useblock code issue

---------

Co-authored-by: vgoodric <vgoodric@adobe.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

* MWPW-161606 [MEP] Modify within modals with MEP (#3171)

initial commit publish

Co-authored-by: viloria <viloria@adobe.com>

* add conditionals

---------

Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
Co-authored-by: viloria <viloria@adobe.com>

* [MWPW-161782] - Added logo changes for older GNAV experience (#3162)

* Added logo changes for older GNAV experience

* Lint Fix

* Logo alighned to left for older GNAV

* [MWPW-161563] CDT Overlap in Global and APAC Promotion file (#3168)

* Use schedule as source for CDT

* seperate start and end

* Added unit tests

* [MWPW-157451] [Accessibility] Merch cards | Focus is lost on comparing plans section (#3103)

* remive tabindex=0 as the attributes from merchcard div

* fresh commit with same changes as commit 1 after resolving the merge conflict

* Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added.

* Revert "Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added."

This reverts commit 610807a.

* run build in mas

* run build

---------

Co-authored-by: Rohit Sahu <rosahu@adobe.com>

* MWPW-159381: Replaces CSS 'body *' with '.consonant-Wrapper *' (#3152)

* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.

* [MWPW-159903] Fix quiz video marquees (#3009) (#3013)

fix quiz marquees

* [MWPW-159328] handle a case where there are not placeholders availabl… (#3014)

[MWPW-159328] handle a case where there are not placeholders available (#2998)

* [MWPW-159328] handle a case where there are not palceholders availble

* fixed typos

---------

Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>

* MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023)

* stash

* stash

* stash

* working well

* set updated command list for inline

* remove querySelector function

* unit test and custom block fix

* updates for in-block

* merch-card-collection unit test fixed

* unit test updates

* more unit test repair

* linting errors

* more linting

* Fix Invalid selector test

* add coverage

* force git checks to refire

* remove comment

* pass rootEl to getSelectedElements for use when needed (gnav)

* skip if clause in codecov

---------

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: markpadbe <markp@adobe.com>

* MWPW-158455: Promobar overlays with localnav elements in devices (#2991)

* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.

* Changing z-index of promobar and popup

* Changing z-index of promobar and popup

* Reverting z-index to 4 for promobar

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Akansha Arora <>

* Replaces CSS 'body *' with '.consonant-Wrapper *'

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: markpadbe <markp@adobe.com>
Co-authored-by: Akansha Arora <akanshaarora090@gmail.com>

* [MWPW-160948] Remove blockquote default spacing (#3159)

* [MWPW-161098] Environment-aware links support for CaaS (#3165)

* relative urls caas support

* added unit tests

* [MWPW-162059] - Fix for vertical alignment of logo on AH (#3180)

Fix for verticle alignment of logo

* Global links underlined by default (#3166)

* a links underline, a.quite added

* added styles to omit header/footer

* added default link styles for headlines and lockup area

* minor :hover style alignment on cards-horiz, marquee-anchors, brick

* removed dubs underline on links

* removed styles overrides to support double in horiz-card, marquee-anch, brick

* [MWPW-145672] Remove Gnav global link styles

* [MWPW-161624] Link farm double underline on focus

* Ensure sub text in anchors is underlined correctly

* Ensure sub text in anchors is underlined correctly

---------

Co-authored-by: thi64146 <thi64146@adobe.com>

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3183)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#2986)"

This reverts commit f379815.

Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>

* [MWPW-145672] Change link color only on hover (#3186)

---------

Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
Co-authored-by: viloria <viloria@adobe.com>
Co-authored-by: Rahul Gupta <rahulgupta999@gmail.com>
Co-authored-by: rohitsahu <sahurohit9@gmail.com>
Co-authored-by: Rohit Sahu <rosahu@adobe.com>
Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com>
Co-authored-by: markpadbe <markp@adobe.com>
Co-authored-by: Akansha Arora <akanshaarora090@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: thi64146 <thi64146@adobe.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@bandana147 bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tedAir @Dli3 @JackySun9 @Roycethan @mokimo @bandana147 @markpadbe @chrischrischris @salonijain3