Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155079 [MILO][MEP] Manifests not changing domains #2626

Merged
merged 66 commits into from
Jul 31, 2024
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
c3b1675
replace overridePersonalizationVariant function
markpadbe Jun 5, 2024
06d62a1
Fix chaining
markpadbe Jun 5, 2024
ee8a2f5
Move parseMepParam
markpadbe Jun 5, 2024
c027c7d
Merge branch 'stage' into mepplaceholdersfix
markpadbe Jun 6, 2024
13239e9
add additional optional chaining operator
markpadbe Jun 6, 2024
96d95a0
Merge branch 'stage' into mepplaceholdersfix
markpadbe Jun 10, 2024
2ae612c
Refactor personalization.js
markpadbe Jun 10, 2024
14cfa36
Remove comment
markpadbe Jun 10, 2024
facdd89
Merge branch 'stage' into orggetpersconfigfrommepplaceholderfix
markpadbe Jun 11, 2024
50e70c4
Merge branch 'stage' into addattributetocontent
markpadbe Jun 17, 2024
3040c0f
Merge branch 'stage' into addattributetocontent
markpadbe Jun 18, 2024
b35f50c
Add TargetManifestId
markpadbe Jun 19, 2024
d970cf3
Remove comment
markpadbe Jun 19, 2024
0596c51
Merge branch 'stage' into addattributetocontent
markpadbe Jun 19, 2024
79bc4b0
Add targetManifestId test
markpadbe Jun 19, 2024
db65362
Refactor addMepHighlightAndTargetManifestIdGnav
markpadbe Jun 19, 2024
d12d910
Merge branch 'stage' into addattributetocontent
markpadbe Jun 20, 2024
41e8b6e
Remove console.log from test
markpadbe Jun 20, 2024
4ec5a68
Shorten function name
markpadbe Jun 20, 2024
ad338e6
Limits targetManifestId to target exp and adds missing name to manif…
markpadbe Jun 21, 2024
040b917
Fix test
markpadbe Jun 21, 2024
f035ff3
Handle default selectedVariant issue
markpadbe Jun 21, 2024
b7e5078
Merge branch 'stage' into addattributetocontent
markpadbe Jun 24, 2024
d2889b5
Merge branch 'stage' into addattributetocontent
markpadbe Jun 25, 2024
d7d0a61
Mostly done
markpadbe Jun 26, 2024
e6165de
Merge branch 'stage' into mepmovefromutils
markpadbe Jun 26, 2024
2575746
Merging in prop display update
markpadbe Jun 26, 2024
54ffc93
Unit tests fixed
markpadbe Jun 27, 2024
9f58549
Add targetmanifestid to useblockcode
markpadbe Jun 28, 2024
9ad9ff0
refactor to remove unnecessary import
markpadbe Jun 28, 2024
92ebe73
Merge branch 'stage' into mepmovefromutils
markpadbe Jun 28, 2024
217bc55
Remove commented code
markpadbe Jun 28, 2024
896f7f8
Removing unused functions
markpadbe Jun 28, 2024
c8732c9
Update tests, not including replacePage
markpadbe Jun 28, 2024
bdd70cb
Merge branch 'stage' into mepmovefromutils
vgoodric Jul 8, 2024
9e2b1a9
Shorten Function Name
vgoodric Jul 8, 2024
7e9e429
move insert inline back to fragment.js
vgoodric Jul 8, 2024
09d0660
additional cleanup and unit tests
vgoodric Jul 12, 2024
e92d657
Merge branch 'stage' into mepmovefromutils
vgoodric Jul 12, 2024
b596bd6
Fix adobeTargetTestId issues
markpadbe Jul 15, 2024
ee6442b
add optional chaining
markpadbe Jul 16, 2024
8c303a3
Update condition for addAnalyticsForUseBlockCode
markpadbe Jul 16, 2024
d849e5a
Refactor to handle analytics for updatemetadata
markpadbe Jul 16, 2024
3f76c59
Merge branch 'stage' into mepmovefromutils
markpadbe Jul 16, 2024
2455740
Fix useBlockCode test
markpadbe Jul 17, 2024
c6828e0
Merge branch 'stage' into mepmovefromutils
markpadbe Jul 17, 2024
bb80188
Fix merged merged test
markpadbe Jul 17, 2024
be67468
Remove applyPers from preload fragments test
markpadbe Jul 17, 2024
904054e
Fix martech init post-merge
markpadbe Jul 18, 2024
c9c16a7
Fix tests and martech merge cleanup
markpadbe Jul 18, 2024
5a62381
Merge branch 'stage' into mepmovefromutils
markpadbe Jul 18, 2024
201d91c
Dynamically import personalization.js
markpadbe Jul 19, 2024
3e75fa8
Merge branch 'stage' into mepmovefromutils
markpadbe Jul 22, 2024
89dba06
add 2 ignore comments
vgoodric Jul 22, 2024
7061942
add conditional chaining
vgoodric Jul 22, 2024
22a4273
Remove mwpw-146528 temp files
markpadbe Jul 22, 2024
f2b4da6
MWPW-152275 Move manifest.json request up while waiting on sstats / e…
vgoodric Jul 23, 2024
53a9951
Add nullish coalescing assignment suggestion
markpadbe Jul 23, 2024
790ae10
MWPW-154998 [MEP][MILO] Manifests do not execute in the right order w…
vgoodric Jul 24, 2024
f3d80b1
normalizePath
vgoodric Jul 24, 2024
1354334
Merge branch 'stage' into mepnormalizepath
vgoodric Jul 25, 2024
4ad0930
Merge branch 'mepmovefromutils' into mepnormalizepath
vgoodric Jul 25, 2024
c0ec273
add normalizePath back into preload
vgoodric Jul 25, 2024
f4e8889
Merge branch 'stage' into mepnormalizepath
markpadbe Jul 29, 2024
e7e15c4
Merge branch 'stage' into mepnormalizepath
markpadbe Jul 30, 2024
a189dc8
MWPW-155568 [MILO][MEP] If MEP is completely off, mep param should st…
vgoodric Jul 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/features/personalization/personalization.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function checkSelectorType(selector) {

const fetchData = async (url, type = DATA_TYPE.JSON) => {
try {
const resp = await fetch(url);
const resp = await fetch(normalizePath(url));
if (!resp.ok) {
/* c8 ignore next 5 */
if (resp.status === 404) {
Expand Down Expand Up @@ -952,8 +952,8 @@ export async function init(enablements = {}) {
manifests = manifests.concat(await combineMepSources(pzn, promo, mepParam));
manifests?.forEach((manifest) => {
if (manifest.disabled) return;
const localizedURL = localizeLink(manifest.manifestPath);
loadLink(localizedURL, { as: 'fetch', crossorigin: 'anonymous', rel: 'preload' });
const normalizedURL = normalizePath(manifest.manifestPath);
loadLink(normalizedURL, { as: 'fetch', crossorigin: 'anonymous', rel: 'preload' });
});
}

Expand Down