Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2641

Merged
merged 6 commits into from
Jul 30, 2024
Merged

[Release] Stage to Main #2641

merged 6 commits into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. [MWPW-151517] - Remove condition for promobar hidden on mobile from g… 

    …nav (#2538)

* Remove condition for promobar hidden on mobile from gnav

* Fix lint and UT

* Adjust height for feds promobar

* brnach banner not shown in case feds promobar is present

* Add UT for promobar hide/show on mobile

* Lint Fix

* Removed condition for on and off feds promobar on mobile to avoid CLS issue

* Remove UT changes not needed now

* fixed mega menu height if promobar is present

* Fix review comments

* Fix megamenu scroll issue

* reverted condition

* remove flex wrap

* add initial visibility hidden for gnav

---------

Co-authored-by: nishantka <nishantkaushikadobe@gmail.com>
    @Deva309 @nishantka
    Deva309 and nishantka authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    386f817 View commit details
    Browse the repository at this point in the history

  2. Mwpw 147034: Custom border color + badge/border color decoupling [mer… 

    …ch card] (#2613)

* MWPW-147907: Allow for 24pt font size for price [Merch Card]

* merch-card dependency consumption

* Update merch-card.js

* Update merch-card.js

* Update merch-card.js
    @Axelcureno
    Axelcureno authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    925af3f View commit details
    Browse the repository at this point in the history

  3. MWPW-150557 - Split Marquee CLS issues on consuming sites (#2636) 

    remove height auto to test CLS issue

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
    @ryanmparrish @milo-pr-merge
    ryanmparrish and milo-pr-merge[bot] authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0ff20f7 View commit details
    Browse the repository at this point in the history

  4. [MWPW-154335] [callout] Spacing issue encountered when the call-out s… 

    …ection is added (#2628)

* milo libs copied with local changes.
Code updated to create only single callout-text slot

* merch-card copied from mas repo

* replaced merch-card changes

* lean up

* replace merch-card from main

---------

Co-authored-by: Rohit Sahu <rosahu@adobe.com>
    @rohitsahu
    rohitsahu and Rohit Sahu authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    fc10fa5 View commit details
    Browse the repository at this point in the history

  5. MWPW-153580: Add Opt-In Feature for CaaS Badge Display (#2625) 

    * Add Opt-In Feature for CaaS Badge Display

* Updates for unit tests

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
    @sanrai @milo-pr-merge
    sanrai and milo-pr-merge[bot] authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    03980fd View commit details
    Browse the repository at this point in the history

  6. [MWPW-153611] [Gray Box] environment aware links (#2622) 

    make graybox urls environment aware
    @robert-bogos
    robert-bogos authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c00c777 View commit details
    Browse the repository at this point in the history