Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2666

Merged
merged 8 commits into from
Aug 5, 2024
Merged

[Release] Stage to Main #2666

merged 8 commits into from
Aug 5, 2024

Commits on Jul 31, 2024

  1. MWPW-155079 [MILO][MEP] Manifests not changing domains (#2626) 

    * replace overridePersonalizationVariant function

* Fix chaining

* Move parseMepParam

* add additional optional chaining operator

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

* Refactor personalization.js

* Remove comment

* Add TargetManifestId

* Remove comment

* Add targetManifestId test

* Refactor addMepHighlightAndTargetManifestIdGnav

* Remove console.log from test

* Shorten function name

* Limits targetManifestId to target exp and adds missing name to  manifestId

* Fix test

* Handle default selectedVariant issue

* Mostly done

* Merging in prop display update

* Unit tests fixed

* Add targetmanifestid to useblockcode

* refactor to remove unnecessary import

* Remove commented code

* Removing unused functions

* Update tests, not including replacePage

* Shorten Function Name

* move insert inline back to fragment.js

* additional cleanup and unit tests

* Fix adobeTargetTestId issues

* add optional chaining

* Update condition for addAnalyticsForUseBlockCode

* Refactor to handle analytics for updatemetadata

* Fix useBlockCode test

* Fix merged merged test

* Remove applyPers from preload fragments test

* Fix martech init post-merge

* Fix tests and martech merge cleanup

* Dynamically import personalization.js

* add 2 ignore comments

* add conditional chaining

* Remove mwpw-146528 temp files

* MWPW-152275 Move manifest.json request up while waiting on sstats / etc. (#2608)

* add preload

* shorten if and and conditional chaining

* run loop even if Target is off

* Add nullish coalescing assignment suggestion

* MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (#2616)

* add default execution order

* unit test

* normalizePath

* add normalizePath back into preload

* MWPW-155568 [MILO][MEP] If MEP is completely off, mep param should still show button (#2658)

don't return if param is present but empty

---------

Co-authored-by: markpadbe <markp@adobe.com>
Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
    @vgoodric @markpadbe
    3 people authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f997015 View commit details
    Browse the repository at this point in the history

  2. MWPW-146030 and MWPW-143704 Add fresco-any and cc-paid-no-stock (#2657) 

    add entitlements
    @vgoodric
    vgoodric authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    40d33fc View commit details
    Browse the repository at this point in the history

  3. Attaching loadblock to window to provide alternative way of loading t… 

    …he script (#2660)

Attaching loadblock to window
    @bandana147
    bandana147 authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9119d26 View commit details
    Browse the repository at this point in the history

  4. MWPW-155316 - Fixing Pill Notification edge cases (#2639) 

    * handling pill edge cases

* pill edge case styles

* update tests to fix coverage

* correction to previous commit

* updates based on PR feedback

* more simplifying

* adding an additional filter

* style tweak

* change inline size for desktop pills

* revert of icon sizing

* revert of ribbon revert
    @elan-tbx
    elan-tbx authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4b9f622 View commit details
    Browse the repository at this point in the history

  5. Correctly pass on the dataset (#2651)

    @mokimo
    mokimo authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    bd509ff View commit details
    Browse the repository at this point in the history

  6. MWPW-155289: Fixed filtering and sorting in catalog sidenav (#2653) 

    handled empty hash case in deeplink
    @mirafedas
    mirafedas authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cf222e0 View commit details
    Browse the repository at this point in the history

  7. MWPW-154124: use preview index (#2654) 

    * MWPW-154124: use preview index

* should remove both links
    @3ch023
    3ch023 authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f44fdb6 View commit details
    Browse the repository at this point in the history

  8. [AUTOMATED-PR] Update imslib.min.js dependency (#2659) 

    Update self hosted dependency

Co-authored-by: GitHub Action <action@github.com>
    @github-actions @actions-user
    github-actions[bot] and actions-user authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    071a858 View commit details
    Browse the repository at this point in the history