MWPW-154098: Retain Modal param while traversing back from Commerce to Page #2781
Conversation
mirafedas
requested review from
yesil,
Axelcureno,
rahulgupta999,
3ch023,
rohitsahu,
bozojovicic,
seanchoi-dev and
adgaurgit
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2781 +/- ##
=======================================
Coverage 96.30% 96.31%
=======================================
Files 242 242
Lines 54981 55019 +38
=======================================
+ Hits 52950 52991 +41
+ Misses 2031 2028 -3 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
mirafedas
force-pushed
the
mwpw-154098-catalog-modal-hash
branch
from
9c1e5c4
to
720538c
Compare
libs/blocks/merch/merch.js
Outdated
| const authoredHash = checkoutLinkConfig[`${(offerType === OFFER_TYPE_TRIAL) ? FREE_TRIAL_HASH : BUY_NOW_HASH}`]; | ||
| const autogeneratedHash = `${offerType === 'TRIAL' ? 'try' : 'buy'}-${el.closest('merch-card')?.getAttribute('name')}`; | ||
| const hash = authoredHash ?? autogeneratedHash; | ||
| el.setAttribute('hash', hash); |
There was a problem hiding this comment.
hash it not a standard attribute, can you use data-modal-hash?
There was a problem hiding this comment.
I changed to data-modal-hash to not mix it with other buttons that use data-modal-hash
mirafedas
force-pushed
the
mwpw-154098-catalog-modal-hash
branch
from
047c360
to
559be32
Compare
mirafedas
force-pushed
the
mwpw-154098-catalog-modal-hash
branch
from
6190111
to
61c4c59
Compare
When users open a modal by clicking a CTA on a merch card, navigate away, and then return, the modal needs to reopen automatically. However, this wasn't working because our catalog page uses custom modals without updating the URL hash. As a result, the URL doesn't retain information about the previously open modal.
To address this, this PR introduces URL hash management. We now add a hash to the URL whenever a modal is opened and remove it when the modal is closed. On page load, each CTA is assigned a unique hash. If the browser's URL contains the hash of a previously opened modal, we automatically trigger a click on the corresponding CTA to reopen the modal.
Resolves: MWPW-154098
Test URLs:
For PSI check: https://mwpw-154098-catalog-modal-hash--milo--mirafedas.hlx.live/docs/authoring/promotions/delayed-modal?martech=off&georouting=off&mep=off