MWPW-158776 Fix video CLS #2915
Conversation
mokimo
requested review from
ryanmparrish,
Sartxi,
auniverseaway and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2915 +/- ##
==========================================
- Coverage 98.21% 96.27% -1.95%
==========================================
Files 64 238 +174
Lines 7848 54495 +46647
==========================================
+ Hits 7708 52465 +44757
- Misses 140 2030 +1890 ☔ View full report in Codecov by Sentry. |
mokimo
requested review from
narcis-radu,
overmyheadandbody,
elan-tbx and
robert-bogos
and removed request for
auniverseaway
|
Not sure how codecov fails 🤷 |
|
Hello @mokimo , issue is seen in url in cc, can you please check |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
* fix cls by adding the videoEl without a source * adapt the video hover and in view port play * Remove no-lazy and return earlier * Fix linting issue * Consolidate duplicated logic * Move functions into the init function * Move root margin and use optional chaining * Only query for the videoEl once
|
@spadmasa - this is a CC specific issue due to consuming code altering the block. @aishwaryamathuria is having a look, but we can't proceed until it is fixed/prepared on the CC project. |
|
Skipped merging 2915: MWPW-158776 Fix video CLS due to failing checks |
3 similar comments
|
Skipped merging 2915: MWPW-158776 Fix video CLS due to failing checks |
|
Skipped merging 2915: MWPW-158776 Fix video CLS due to failing checks |
|
Skipped merging 2915: MWPW-158776 Fix video CLS due to failing checks |
* stage: MWPW-158886: update the way we send arbitrary fields to caas (adobecom#2977) MWPW-159028: MAS more technical documents + refactored aem related code (adobecom#2952) MWPW-158776 Fix video CLS (adobecom#2915) MWPW-159197 Invoke onReady of standalone gnav when it is rendered adobecom#2962 (adobecom#2963) MWPW-159157: Update modal to account for new image size (adobecom#2975) Reverts MWPW-157555: Causing prices and CTAs to fail in Safari (adobecom#2987) [MWPW-159287 : NALA] Enhance Nala Run Command to Support Feature Branches with with an owner other than 'adobecom' (adobecom#2978) [MWPW-158927] Countdown Timer feedbacks incorporated (adobecom#2955) [MWPW-159265] Callout text in RTL not properly aligned (adobecom#2974) Add support for Jarvis through Unav and make appID of notifications configurable (adobecom#2969) MWPW-159236 Fix duplicate percent in donut chart tooltip (adobecom#2968) MWPW-144360 Prototype pollution tag selector (adobecom#2967) [MWPW-153616] Update 404 links in region selector (adobecom#2956) MWPW-157555: Remove useless logic and putting import commerce.js top. (adobecom#2906) # Conflicts: # libs/deps/mas/mas.js # libs/deps/mas/merch-card.js # libs/deps/mas/plans-modal.js # libs/features/mas/web-components/src/global.css.js
Follow up for the reverted PR #2849
Resolves: MWPW-158776
This should still work: #1936
Test URLs:
Onhover play
Onviewport play
Only desktop (mobile should not load the video for perf reasons)
Split marquee video tests
Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/marquee-split?martech=off
After: https://marquee-cls--milo--mokimo.hlx.page/docs/library/kitchen-sink/marquee-split?martech=off
Before: https://main--cc--adobecom.hlx.page/drafts/00-CC-milo-migration/bugs/document?martech=off
After: https://main--cc--adobecom.hlx.page/drafts/00-CC-milo-migration/bugs/document?martech=off&milolibs=marquee-cls--milo--mokimo
CLS
Bacom tests
CC tests