-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-155315 Set Marketo POI #2938
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2938 +/- ##
==========================================
+ Coverage 96.30% 96.31% +0.01%
==========================================
Files 242 242
Lines 54981 54998 +17
==========================================
+ Hits 52950 52972 +22
+ Misses 2031 2026 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small comments. Also, you've got some eslint and nala errors
55b4e76
to
4a53605
Compare
4a53605
to
3e71e5f
Compare
3e71e5f
to
697de6d
Compare
Fixed eslint and nala errors, project code coverage appears to be bugged. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
697de6d
to
981fe08
Compare
981fe08
to
daa9ffd
Compare
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Resolves: MWPW-155315
Test URLs:
BACOM URLs: