Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2943

Merged
merged 7 commits into from
Sep 25, 2024
Merged

[Release] Stage to Main #2943

merged 7 commits into from
Sep 25, 2024

Conversation

* Fix: Adding configurable help component children

* Lint fix
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 24, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Sep 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 24, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.error('Global navigation Error: header and footer configurations are missing.');

@mokimo mokimo requested a review from a team as a code owner September 24, 2024 08:48
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 99.10714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (b600045) to head (5ddeb73).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
libs/utils/decorate.js 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   96.27%   96.29%   +0.01%     
==========================================
  Files         239      240       +1     
  Lines       54669    54739      +70     
==========================================
+ Hits        52634    52709      +75     
+ Misses       2035     2030       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* content navigation

* fix tests

* update builds

* fix codecov

* update spectrum version

* ignore line for codecov

* ignore line for codecov

* remove ignore line for codecov

* update tests

* fix tests and regression slot resizing

* PR feedbacks

* fix code coverage by removing dead code

* fix code coverage by removing dead code

* fix code coverage by removing dead code

* update import

* update import
@mokimo mokimo requested a review from a team as a code owner September 24, 2024 08:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/src/variants/catalog.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/src/variants/mini-compare-chart.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/src/variants/special-offer.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/src/variants/variant-layout.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/src/variants/variants.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/test/aem.test.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/test/merch-card.mini-compare.mobile.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/test/merch-card.mini-compare.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/test/merch-card.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/mas/web-components/test/merch-datasource.test.html.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/action-button.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/action-menu.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/alert-dialog.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/base.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/button-group.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/button.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/checkbox.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/dialog.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/divider.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/field-label.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/help-text.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icon.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons-ui.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons-workflow.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/asterisk.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/checkmark.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/chevron.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/corner-triangle.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/cross.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/icons/dash.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/link.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/menu.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/overlay.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/picker.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/popover.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/progress-circle.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/reactive-controllers.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/search.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/shared.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/sidenav.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/tabs.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/textfield.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/theme.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/toast.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/tooltip.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/tray.js


⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f70f94b51e21bc80dbaafc479a8bfa912449e391/libs/features/spectrum-web-components/dist/underlay.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

@seanchoi-dev seanchoi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My parts are looking good.

@milo-pr-merge milo-pr-merge bot merged commit 3d3a739 into main Sep 25, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.