-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-158004] Fix callout & grey line alignment issues in product merch cards #2946
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2946 +/- ##
==========================================
- Coverage 96.30% 96.30% -0.01%
==========================================
Files 242 242
Lines 54873 54951 +78
==========================================
+ Hits 52845 52918 +73
- Misses 2028 2033 +5 ☔ View full report in Codecov by Sentry. |
I don't see a difference between before and after pages. Is that expected? |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Fixed. Moved the test URL to Milo as the DC URL was not picking the branch from my fork |
|
libs/features/mas/web-components/test/merch-card-product.test.html.js
Outdated
Show resolved
Hide resolved
@rahulgupta999 Verified and regression covered. Observed few more issues in the latest cards tracking here since they are already exists in main: https://jira.corp.adobe.com/browse/MWPW-159140 otherwise marking "Verified" Also @npeltier 's approval is pending here.... |
I divided the body-xs slot to put the callout content between the body-xs and footer. The change was done only for the product card. The alignment strategy is the same as for mini-compare charts, where we set a minimum height for each slot.
Resolves: MWPW-158004
Test URLs: