Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159032: Defaults to empty alt tag on the svg - Accessibility requirement #2947

Closed
wants to merge 1 commit into from

Conversation

joaquinrivero
Copy link
Contributor

@joaquinrivero joaquinrivero commented Sep 25, 2024

*This exist before, and we are getting request by accessibility to added again for unity project

  • Defaults to empty alt tag on the image if no alt text is authored. Per accessibility best practices this declares the image as "decorative".

Resolves: MWPW-159032
Test URLs:

@joaquinrivero joaquinrivero requested a review from a team as a code owner September 25, 2024 01:27
@joaquinrivero joaquinrivero marked this pull request as draft September 25, 2024 01:28
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (5ddeb73) to head (2be5f77).
Report is 39 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2947      +/-   ##
==========================================
- Coverage   96.29%   95.96%   -0.33%     
==========================================
  Files         240      175      -65     
  Lines       54739    46838    -7901     
==========================================
- Hits        52709    44950    -7759     
+ Misses       2030     1888     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Oct 3, 2024
@joaquinrivero joaquinrivero marked this pull request as ready for review October 4, 2024 14:21
@joaquinrivero joaquinrivero deleted the MWPW-159032 branch October 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant